-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Generic Exceptions #1428
Comments
There are only 5 places left after #1537, not taking into account examples/tests/tests generators:
And taking everything else into account its 15:
|
ekilmer
added a commit
that referenced
this issue
Oct 18, 2019
* master: Remove generic exceptions (#1428) (#1537) Add missing will_write_memory event in write_bytes (#1535) Fix #1533 (#1534) Unsigned div constant folding simplification (#1530) ADDMOD and MULMOD fixes (#1531) perf: avoid multiple calls to read same self.PC (#1527) Adds test for memory max_exec_size (#1524) Add partial implementation of recvfrom syscall (#1514) perf: optimize decode_instruction (#1522) Clean-up log (#1520) Added storage change detection plugin (#1507) Add serialization/deserialization log messages. (#1518) Eliminate bogus generate_testcase argument. (#1517) Expose hard-coded dynamic load address for ELF sections (#1515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use
raise Exception
in 47 different places. Not all of those are in unit tests. As a general rule, we should change these to more-specific exceptions so that it's easier to catch specific issues.The text was updated successfully, but these errors were encountered: