Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: have pytest report 100 slowest tests #1646

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

bradlarsen
Copy link
Contributor

This change merely passes an extra argument to pytest when it's invoked via GitHub Actions, so that the 100 slowest tests are reported. This information is useful to identify possible places to tighten up the test suite.

Copy link
Contributor

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Example of output:

857.77s call     tests/ethereum/test_detectors.py::EthDelegatecall::test_delegatecall_ok2
396
630.13s call     tests/ethereum/test_sha3.py::EthSha3TestFake::test_essence2
397
410.80s call     tests/ethereum/test_plugins.py::EthPluginsTests::test_ignore_states
398
392.63s call     tests/ethereum/test_sha3.py::EthSha3TestSymbolicate::test_essence2
399

@reaperhulk
Copy link
Contributor

codecov delivering the nonsense with coverage (why is merged coverage such a challenge for these stupid services) so ignoring and merging.

@reaperhulk reaperhulk merged commit 87b6bad into master Mar 31, 2020
@reaperhulk reaperhulk deleted the pytest-durations branch March 31, 2020 23:50
ekilmer added a commit to ekilmer/manticore that referenced this pull request Apr 7, 2020
* master:
  Bump to CheckoutV2 (trailofbits#1654)
  Add support for `sys_arm_fadvise64_64` (trailofbits#1648)
  Add __slots__ to expressions (trailofbits#1635)
  Swap remaining uses of `Z3Solver()` to use the singleton interface (trailofbits#1649)
  CI: have pytest report 100 slowest tests (trailofbits#1646)
  Add a syscall implementation for `llseek` (trailofbits#1640) (and some type hints)
  Added support for proc/self/maps (trailofbits#1639)
  Add missing support for ARM modified immediate encodings (trailofbits#1638)
  Transparently compress & decompress persisted state files (trailofbits#1624)
  Attempt to fix Truffle tests (trailofbits#1637)
  Skip basic blocks that unavoidably end in REVERT. (trailofbits#1630)
ekilmer added a commit that referenced this pull request Apr 23, 2020
* master: (28 commits)
  Rework syscall invocation for proper behavior under typeguard (#1672)
  printable_bytes (#1671)
  Fix several incorrect type hints (#1668)
  Add type hints to several parts of Manticore (#1667)
  Fix type confusion in manual CPU tests; delete dead testing code (#1669)
  Rework WASM Imports and Fix Typos (#1666)
  Work on "Model is not Available" errors in tests (#1659)
  Fix TypeGuard Errors in WASM Module (#1601)
  Remove unused arg ans separate output from workspace (#1651)
  Add a badge to README.md for LGTM (#1647)
  Fix 2 problems in Linux `sys_open` support & add type hints (#1657)
  Fix LGTM Errors (#1656)
  Delay WASM Branch Condition Concretization (#1641)
  Add feature for SymbolicSocket through sys_accept (#1618)
  Add a bunch of type hints & fix a few issues with Linux platform emulation (#1645)
  Bump to CheckoutV2 (#1654)
  Add support for `sys_arm_fadvise64_64` (#1648)
  Add __slots__ to expressions (#1635)
  Swap remaining uses of `Z3Solver()` to use the singleton interface (#1649)
  CI: have pytest report 100 slowest tests (#1646)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants