Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on "Model is not Available" errors in tests #1659

Merged
merged 6 commits into from
Apr 10, 2020

Conversation

ehennenfent
Copy link
Contributor

It's gotten annoying how they spontaneously kill our builds. I'd like to find out what's going on, especially if they're genuinely due to resource constraints.

@ehennenfent ehennenfent marked this pull request as ready for review April 8, 2020 23:48
@ehennenfent
Copy link
Contributor Author

I've built this several times but haven't been able to get it to exhibit the "Model is not available" error. Perhaps we should merge it so we'll be able to see what's going on next time the error happens?

@ehennenfent ehennenfent requested a review from ekilmer April 9, 2020 23:30
Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehennenfent
Copy link
Contributor Author

@ekilmer thanks for reviewing. I don't know if we want to add another dependency to the main build, but for now I'm going to merge as I can't seem to trigger the "Model not available" error on this branch, despite it happening frequently on master. Before our next release, we can consider removing it.

@ehennenfent ehennenfent merged commit 1e23f7a into master Apr 10, 2020
@ehennenfent ehennenfent deleted the dev-available-models branch April 10, 2020 00:29
ekilmer added a commit that referenced this pull request Apr 23, 2020
* master: (28 commits)
  Rework syscall invocation for proper behavior under typeguard (#1672)
  printable_bytes (#1671)
  Fix several incorrect type hints (#1668)
  Add type hints to several parts of Manticore (#1667)
  Fix type confusion in manual CPU tests; delete dead testing code (#1669)
  Rework WASM Imports and Fix Typos (#1666)
  Work on "Model is not Available" errors in tests (#1659)
  Fix TypeGuard Errors in WASM Module (#1601)
  Remove unused arg ans separate output from workspace (#1651)
  Add a badge to README.md for LGTM (#1647)
  Fix 2 problems in Linux `sys_open` support & add type hints (#1657)
  Fix LGTM Errors (#1656)
  Delay WASM Branch Condition Concretization (#1641)
  Add feature for SymbolicSocket through sys_accept (#1618)
  Add a bunch of type hints & fix a few issues with Linux platform emulation (#1645)
  Bump to CheckoutV2 (#1654)
  Add support for `sys_arm_fadvise64_64` (#1648)
  Add __slots__ to expressions (#1635)
  Swap remaining uses of `Z3Solver()` to use the singleton interface (#1649)
  CI: have pytest report 100 slowest tests (#1646)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants