Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialized iterative serialization for Array #1756

Merged
merged 2 commits into from Jun 30, 2020

Conversation

feliam
Copy link
Contributor

@feliam feliam commented Jun 25, 2020

This PR improves performance on serializing large ArrayStores. Pickling large ArrayStores would previously result in very deep recursion, which sometimes hit the python stack limit and caused a crash. Now, ArrayStores will iterate over their contents so that we instead pickle a flattened version.

@ehennenfent ehennenfent added this to Review in progress in Manticore Jun 30, 2020
Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Should be well-covered by the existing tests.

Manticore automation moved this from Review in progress to Reviewer approved Jun 30, 2020
@feliam feliam merged commit e265bce into master Jun 30, 2020
Manticore automation moved this from Reviewer approved to Done Jun 30, 2020
@feliam feliam deleted the dev-iterative-array-serialization branch June 30, 2020 18:15
ekilmer added a commit that referenced this pull request Jul 17, 2020
* master:
  Create a model for strncpy (#1770)
  Add doc, fix output bugs (#1769)
  Update EVM usage example (#1772)
  New working model of strlen (#1725)
  Typo (#1768)
  Specialized iterative serialization for Array (#1756)
  Enable nightly uploads to PyPI (#1757)
  Manticore 0.3.4 (#1720)
  Manticore verifier (#1717)
  Nightly MacOS Tests (#1614)
  Remove/procrastinate solver query in ether leak detector (#1727)
  Fix constant folding & constraint set slicing (#1706)
@ehennenfent ehennenfent added this to the Manticore 0.3.5 milestone Sep 3, 2020
@ehennenfent ehennenfent mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Manticore
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants