Update EVM usage example #1772
Merged
Update EVM usage example #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
feliam
approved these changes
Jul 9, 2020
|
@feliam that's great! Should I close this then if the examples won't run into this issue anymore? Edit: referring to the latest gas and balance changes, which sound like they potentially fix this issue |
|
No no. Old examples are failing because by default now the transaction fee and gas are correctly debited from the caller's balance. We need a specific configuration constant that disables all ethereum balance and gas calculations. So it is easier for the user that is interested in a different aspect of the contract Merging this PR in 3 2 1... |
ekilmer
added a commit
that referenced
this pull request
Jul 17, 2020
* master: Create a model for strncpy (#1770) Add doc, fix output bugs (#1769) Update EVM usage example (#1772) New working model of strlen (#1725) Typo (#1768) Specialized iterative serialization for Array (#1756) Enable nightly uploads to PyPI (#1757) Manticore 0.3.4 (#1720) Manticore verifier (#1717) Nightly MacOS Tests (#1614) Remove/procrastinate solver query in ether leak detector (#1727) Fix constant folding & constraint set slicing (#1706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1771 (at least for the example in the readme). Increases the balance of the created account so the user has enough eth to send the contract creation transaction with the default transaction gas.
It's possible it would be more helpful to specify the gas for
solidity_create_contractinstead, but this keeps the example as simple as possible.