Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node from 13.x to 16.x #2484

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Bump Node from 13.x to 16.x #2484

merged 3 commits into from
Sep 7, 2021

Conversation

G-11-P
Copy link
Contributor

@G-11-P G-11-P commented Aug 27, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@G-11-P G-11-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change anything?

@ehennenfent ehennenfent changed the title Update ci.yml Bump Node from 13.x to 16.x Aug 27, 2021
@ehennenfent
Copy link
Contributor

Thanks for the PR! This seems to be passing tests okay, and puts us on a better-supported version of NPM. Just one thing - would you mind submitting the CLA so that we can merge this? It's linked above

Copy link
Contributor Author

@G-11-P G-11-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

This reverts commit 1d7c80e.
Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted some breaking changes to ci.yml (which look like a copy/paste error?) and this LGTM! Thanks for the PR.

@ehennenfent ehennenfent merged commit 4d880cd into trailofbits:master Sep 7, 2021
@G-11-P G-11-P deleted the patch-1 branch September 8, 2021 13:59
@G-11-P
Copy link
Contributor Author

G-11-P commented Sep 8, 2021

Thank you awesome man i appreciate the assistance!

ekilmer added a commit that referenced this pull request Sep 9, 2021
* master:
  Bump Node from 13.x to 16.x (#2484)
  Copy/Snapshot a RegisterFile (#2489)
  Add more logging messages around solver errors (#2485)
  Add manticore reference property to States (#2486)
  Option to kill Manticore if any state fails on unrecoverable error (#2487)
  Optionally publish events for memory reads (#2488)
ekilmer added a commit that referenced this pull request Oct 30, 2021
* master:
  Add methods for getting list of (un)implemented system calls (#2491)
  Unpin Truffle Version, Use Latest crytic-compile (#2490)
  Add last_executed_pc property to abstract CPU (#2475)
  Bump Node from 13.x to 16.x (#2484)
  Copy/Snapshot a RegisterFile (#2489)
  Add more logging messages around solver errors (#2485)
  Add manticore reference property to States (#2486)
  Option to kill Manticore if any state fails on unrecoverable error (#2487)
  Optionally publish events for memory reads (#2488)
  Install Python3.7 in Docker image (#2482)
  Prioritize LD_LIBRARY_PATH over system default path (#2476)
  track parent in state descriptors (#2479)
  Switch to Python 3.7 (#2472)
  Fix loading custom interpreters for ELF binaries (#2473)
  Create CITATION.cff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants