Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WinVerifyTrust with a cross-platform signature verification API #39

Closed
woodruffw opened this issue Mar 26, 2020 · 4 comments · Fixed by #70
Closed

Replace WinVerifyTrust with a cross-platform signature verification API #39

woodruffw opened this issue Mar 26, 2020 · 4 comments · Fixed by #70
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@woodruffw
Copy link
Member

The only thing blocking winchecksec builds for non-Windows is a single API: WinVerifyTrust.

We should try to remove usage of it in favor of an open-source implementation, of which there should be a few (since Authenticode is basically PKCS#7).

Some potential starting points:

cc @haxmeadroom @ekilmer

@woodruffw woodruffw added the enhancement New feature or request label Mar 26, 2020
@woodruffw
Copy link
Member Author

The WINE WinVerifyTrust impl. doesn't look especially useful: https://source.winehq.org/source/dlls/wintrust/wintrust_main.c

@woodruffw
Copy link
Member Author

As an update: I looked a bit into this last night, and it looks like it'd be pretty easy to do with pe-parse and some OpenSSL. My goal is to make a small cross-platform WinVerifyTrust replacement library in the next week or so.

@woodruffw
Copy link
Member Author

Update: I have a working prototype for this.

@woodruffw
Copy link
Member Author

woodruffw commented Apr 14, 2020

Update: smolverify can do this.

@woodruffw woodruffw self-assigned this Apr 14, 2020
@woodruffw woodruffw mentioned this issue Apr 14, 2020
7 tasks
woodruffw added a commit that referenced this issue May 9, 2020
woodruffw added a commit that referenced this issue May 18, 2020
* treewide: Use uthenticode for Authenticode checks

Closes #39.
@woodruffw woodruffw added this to the 2.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant