Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow loading of external config file #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

armandopadilla
Copy link

The change allows users to load an external autoreload config. If non is provided the default one is used. Essentially, gives the user more control of this pack's underlining behavior without having to touch the npm-module directly.

How to use

  1. Create new file within your trails app. config/autoreload.js
  2. Add content

module.exports = {
cwd: '/srv/project',
ignoreInitial: true,
usePolling: true
}

  1. Reload app.

@scott-wyatt
Copy link
Member

scott-wyatt commented Jul 17, 2016

+1 for this functionality. Are you able to write a test for this as well? Also, please follow the eslint guidelines so that this passes the PR CI tests.

@armandopadilla
Copy link
Author

will do and on it!

Copy link

@disciple-dev disciple-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove semicolons on lines 39 & 42 for CI tests to pass.

@scott-wyatt
Copy link
Member

scott-wyatt commented Oct 12, 2016

This functionality might be solved by trailsjs/trails#236 or trailsjs/trailpack#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants