Change how show data is loaded and prepared from trakt.tv during a sync... #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During sync, when getting show data from trakt.tv build the list instead of reformatting inplace, this allows for checks to be done against impossible shows (a show with no title, imdb id and tvdb id for now)
rectifyer
added a commit
that referenced
this pull request
Feb 21, 2014
Change how show data is loaded and prepared from trakt.tv during a sync...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a sync (TV Show) change how data is handled from trakt.tv.
Instead of reformatting data in place, create a new array, this allows for checking of invalid shows.
An example would be, if a show has no title, no IMDB ID, and no TVDB ID. This will cause the plugin to crash.
Not sure how a show could be in someone's collection with that criteria, but it has happened.
Changes
During sync, when getting show data from trakt.tv build the list instead of reformatting inplace, this allows for checks to be done against impossible shows (a show with no title, imdb id and tvdb id for now)