Fix id handling for manual actions #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ignored the correct ids in some cases and ended up thinking it was a tvdb id, even if we knew better. Rename parseIdToTraktIds to guessBestTraktId as it's clearer on what it actially does. It should only be used, if we don't know which kind of id we're handling, otherwise it will lead us to loose id types. Fixes #530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignored the correct ids in some cases and ended up thinking
it was a tvdb id, even if we knew better.
Rename parseIdToTraktIds to guessBestTraktId as it's clearer on what it
actially does. It should only be used, if we don't know which kind
of id we're handling, otherwise it will lead us to loose id types.
Fixes #530