Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle build already in review when submitting a build for bete review #23

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

nid90
Copy link
Contributor

@nid90 nid90 commented Jul 18, 2023

Closes #21

Expire an older build waiting for review if a newer build comes for the same version name.

Removing the build from review would be a better option than expiring it, but App Store Connect API to remove the build from beta review doesn't exist.

More context: fastlane/fastlane#18408 (comment)

@nid90 nid90 requested a review from kitallis July 18, 2023 15:02
Copy link
Member

@kitallis kitallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nid90 nid90 merged commit 7b0253d into main Jul 18, 2023
1 check passed
@nid90 nid90 deleted the fix/tf-already-in-review branch July 18, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle build already in review when sending a build to external group in TestFlight
2 participants