feat(eslint-config-angular): add most useful rules for async-await (#…

…195)
tramvaijs · Apr 21, 2022 · 015e0d1 · 015e0d1
1 parent 74f4f5a
commit 015e0d1
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/packages/eslint-config-angular/README.md b/packages/eslint-config-angular/README.md
@@ -19,7 +19,8 @@ necessary additional configs.
     "@tinkoff/eslint-config/app",
     "@tinkoff/eslint-config-angular",
     "@tinkoff/eslint-config-angular/html",
-    "@tinkoff/eslint-config-angular/rxjs"
+    "@tinkoff/eslint-config-angular/rxjs",
+    "@tinkoff/eslint-config-angular/promise"
   ]
 }
 ```

diff --git a/packages/eslint-config-angular/package.json b/packages/eslint-config-angular/package.json
@@ -12,6 +12,7 @@
     "index.js",
     "rxjs",
     "html",
+    "promise",
     "ts",
     "README.md"
   ],

diff --git a/packages/eslint-config-angular/promise/index.js b/packages/eslint-config-angular/promise/index.js
@@ -0,0 +1,28 @@
+module.exports = {
+  overrides: [
+    {
+      files: ['*.ts'],
+      parser: '@typescript-eslint/parser',
+      plugins: ['@typescript-eslint'],
+      rules: {
+        'require-await': 'off', // note you must disable the base rule as it can report incorrect errors
+        '@typescript-eslint/require-await': 'error',
+        '@typescript-eslint/await-thenable': 'error',
+        '@typescript-eslint/promise-function-async': [
+          'error',
+          {
+            allowedPromiseNames: ['Thenable'],
+            checkArrowFunctions: true,
+            checkFunctionDeclarations: true,
+            checkFunctionExpressions: true,
+            checkMethodDeclarations: true,
+          },
+        ],
+        '@typescript-eslint/no-floating-promises': [
+          'error',
+          { ignoreVoid: true, ignoreIIFE: true },
+        ],
+      },
+    },
+  ],
+};