Skip to content

Commit

Permalink
feat(eslint-config-angular): decomposition angular complex configs to…
Browse files Browse the repository at this point in the history
… optional configs (#197)
  • Loading branch information
splincode committed Jun 15, 2022
1 parent 7fed0db commit df3c1a3
Show file tree
Hide file tree
Showing 17 changed files with 41 additions and 42 deletions.
7 changes: 5 additions & 2 deletions packages/eslint-config-angular/README.md
Expand Up @@ -13,9 +13,9 @@ npm i --save-dev @tinkoff/eslint-config @tinkoff/eslint-config-angular
Then, need to include `recommendation` configurations sets to `.eslintrc`. We need to choose base configuration, and any
necessary additional configs:

```json
```json5
{
"extends": ["@tinkoff/eslint-config/app", "@tinkoff/eslint-config-angular"]
extends: ['@tinkoff/eslint-config/app', '@tinkoff/eslint-config-angular'],
}
```

Expand All @@ -32,6 +32,9 @@ You can also include `optional` configurations, however, you are responsible for
'@tinkoff/eslint-config-angular/html',
'@tinkoff/eslint-config-angular/rxjs',
'@tinkoff/eslint-config-angular/promise',
'@tinkoff/eslint-config-angular/imports',
'@tinkoff/eslint-config-angular/line-statements',
'@tinkoff/eslint-config-angular/member-ordering',
],
}
```
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/eslint-config-angular/index.js
@@ -1,3 +1,3 @@
module.exports = {
extends: ['./ts/index.js'],
extends: ['./recommended/index.js'],
};
Expand Up @@ -59,13 +59,13 @@ module.exports = {
* [sort: public -> protected -> private]
**/
/*
'public-static-get',
'public-static-set',
'protected-static-get',
'protected-static-set',
'private-static-get',
'private-static-set',
*/
* 'public-static-get',
* 'public-static-set',
* 'protected-static-get',
* 'protected-static-set',
* 'private-static-get',
* 'private-static-set',
*/

/**
* @note(splincode):
Expand All @@ -77,19 +77,19 @@ module.exports = {
* [sort: decorated -> non-decorated]
**/
/*
'public-decorated-get',
'public-instance-get',
'public-decorated-set',
'public-instance-set',
'protected-decorated-get',
'protected-instance-get',
'protected-decorated-set',
'protected-instance-set',
'private-decorated-get',
'private-instance-get',
'private-decorated-set',
'private-instance-set',
*/
* 'public-decorated-get',
* 'public-instance-get',
* 'public-decorated-set',
* 'public-instance-set',
* 'protected-decorated-get',
* 'protected-instance-get',
* 'protected-decorated-set',
* 'protected-instance-set',
* 'private-decorated-get',
* 'private-instance-get',
* 'private-decorated-set',
* 'private-instance-set',
*/

/**
* static methods
Expand Down
9 changes: 6 additions & 3 deletions packages/eslint-config-angular/package.json
Expand Up @@ -9,11 +9,14 @@
"eslint-config"
],
"files": [
"index.js",
"rxjs",
"html",
"imports",
"line-statements",
"member-ordering",
"promise",
"ts",
"recommended",
"rxjs",
"index.js",
"README.md"
],
"scripts": {},
Expand Down
File renamed without changes.
3 changes: 3 additions & 0 deletions packages/eslint-config-angular/recommended/index.js
@@ -0,0 +1,3 @@
module.exports = {
extends: ['./base.js', './base-typescript.js', './extraneous-class.js'],
};
Expand Up @@ -6,7 +6,7 @@ describe('imports / happy path', () => {
cwd: path.join(__dirname, '..'),
useEslintrc: false,
baseConfig: {
extends: ['../ts/base', '../ts/import'],
extends: ['../imports'],
},
});

Expand Down
Expand Up @@ -6,7 +6,7 @@ describe('imports / unhappy path', () => {
cwd: path.join(__dirname, '..'),
useEslintrc: false,
baseConfig: {
extends: ['../ts/base', '../ts/import'],
extends: ['../imports'],
},
});

Expand Down
Expand Up @@ -6,7 +6,7 @@ describe('imports / happy path', () => {
cwd: path.join(__dirname, '..'),
useEslintrc: false,
baseConfig: {
extends: ['../ts/line-statements'],
extends: ['../line-statements'],
},
});

Expand Down
Expand Up @@ -6,7 +6,7 @@ describe('line statements / unhappy path', () => {
cwd: path.join(__dirname, '..'),
useEslintrc: false,
baseConfig: {
extends: ['../ts/line-statements'],
extends: ['../line-statements'],
},
});

Expand Down
Expand Up @@ -6,7 +6,7 @@ describe('member-ordering / happy path', () => {
cwd: path.join(__dirname, '..'),
useEslintrc: false,
baseConfig: {
extends: ['../ts/member-ordering'],
extends: ['../member-ordering'],
},
});

Expand Down
Expand Up @@ -6,7 +6,7 @@ describe('member-ordering / unhappy', () => {
cwd: path.join(__dirname, '..'),
useEslintrc: false,
baseConfig: {
extends: ['../ts/member-ordering'],
extends: ['../member-ordering'],
},
});

Expand Down
10 changes: 0 additions & 10 deletions packages/eslint-config-angular/ts/index.js

This file was deleted.

0 comments on commit df3c1a3

Please sign in to comment.