Add dockerfilelint pre-commit hook

transcom · Jun 7, 2019 · 02647fc · 02647fc
1 parent 7ae20d1
commit 02647fc
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 5 deletions.
diff --git a/.dockerfilelintrc b/.dockerfilelintrc
@@ -0,0 +1,2 @@
+rules:
+  latest_tag: off
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -126,3 +126,9 @@ repos:
       language: script
       files: .codecov.yml
       pass_filenames: false
+
+  - repo: https://github.com/pryorda/dockerfilelint-precommit-hooks
+    rev: v0.1.0
+    hooks:
+    - id: dockerfilelint
+      stages: [commit]
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM gcr.io/distroless/base
+FROM gcr.io/distroless/base:latest
 
 COPY bin/rds-combined-ca-bundle.pem /bin/rds-combined-ca-bundle.pem
 COPY bin/chamber /bin/chamber

diff --git a/Dockerfile.migrations b/Dockerfile.migrations
@@ -14,7 +14,7 @@ ENV GO_ENV=container
 
 # Install tools needed in container
 RUN apk update
-RUN apk add postgresql-client python3 ca-certificates bash
+RUN apk add postgresql-client python3 ca-certificates bash --no-cache
 RUN pip3 install awscli
 
 WORKDIR /scripts

diff --git a/Dockerfile.migrations_local b/Dockerfile.migrations_local
@@ -16,6 +16,6 @@ ENV SECURE_MIGRATION_DIR=/migrate/local
 
 # Install tools needed in container
 RUN apk update
-RUN apk add postgresql-client bash
+RUN apk add postgresql-client bash --no-cache
 
 WORKDIR /scripts
diff --git a/Dockerfile.tasks b/Dockerfile.tasks
@@ -1,4 +1,4 @@
-FROM gcr.io/distroless/base
+FROM gcr.io/distroless/base:latest
 
 COPY bin/rds-combined-ca-bundle.pem /bin/rds-combined-ca-bundle.pem
 COPY bin/chamber /bin/chamber

diff --git a/Dockerfile.tasks_local b/Dockerfile.tasks_local
@@ -1,4 +1,4 @@
-FROM gcr.io/distroless/base
+FROM gcr.io/distroless/base:latest
 
 COPY bin_linux/save-fuel-price-data /bin/save-fuel-price-data