Merge pull request #2775 from transcom/ttv_168758755_fix_storybook_build

Ttv 168758755 fix storybook build

.circleci/config.yml

@@ -534,6 +534,22 @@ jobs:
           repo: app
       - announce_failure
 
+  # `build_storybook_app` builds the storybook application container and pushes to the container repository
+  build_storybook_app:
+    executor: mymove_medium
+    steps:
+      - checkout
+      - setup_remote_docker:
+          docker_layer_caching: true
+      - restore_cache:
+          keys:
+            - v2-cache-yarn-v2-{{ checksum "yarn.lock" }}
+      - restore_cache:
+          keys:
+            - v2-mymove-node-modules-{{ checksum "yarn.lock" }}
+      - run: make storybook_build
+      - announce_failure
+
   # `build_migrations` builds the migrations container and pushes to the container repository
   build_migrations:
     executor: mymove_small
@@ -876,6 +892,11 @@ workflows:
             - pre_deps_yarn
             - acceptance_tests_local # don't bother building and pushing the application if it won't even start properly
 
+      - build_storybook_app:
+          requires:
+            - anti_virus
+            - pre_deps_yarn
+
       - build_tools:
           requires:
             - anti_virus

.storybook/webpack.config.js

@@ -0,0 +1,19 @@
+// remove eslint from the webpack configuration to use the create-react-app eslint config
+const removeEsLint = exports => {
+  return (
+    exports.module.rules
+      .filter(e => e.use && e.use.some(e => e.options && void 0 !== e.options.useEslintrc))
+      .forEach(s => {
+        exports.module.rules = exports.module.rules.filter(e => e !== s);
+      }),
+    exports
+  );
+};
+
+module.exports = async ({ config, mode }) => {
+  // remove eslint from config
+  config = removeEsLint(config);
+
+  // return the new config
+  return config;
+};

Makefile

@@ -859,8 +859,8 @@ spellcheck: .client_deps.stamp ## Run interactive spellchecker
 storybook: ## Start the storybook server
 	yarn run storybook
 
-.PHONY: build_storybook
-build_storybook: ## Build static storybook site
+.PHONY: storybook_build
+storybook_build: ## Build static storybook site
 	yarn run build-storybook
 
 #