Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NoError instead of Nil #2387

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Use NoError instead of Nil #2387

merged 1 commit into from
Jul 12, 2019

Conversation

pjdufour-truss
Copy link
Contributor

@pjdufour-truss pjdufour-truss commented Jul 12, 2019

Description

NoError will print the error as a formatted string (using Error() string) when an error occurs rather just printing the struct.

https://godoc.org/github.com/stretchr/testify/assert#NoError

Reviewer Notes

None

Setup

None

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using scripts/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • User facing changes have been reviewed by design.
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

None

Screenshots

None

Copy link
Contributor

@chrisgilmerproj chrisgilmerproj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 - nice fix!

@pjdufour-truss pjdufour-truss merged commit 444ba37 into master Jul 12, 2019
@pjdufour-truss pjdufour-truss deleted the noerror branch July 12, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants