This PR adds a client_test target to the Makefile #26
Conversation
| @@ -27,7 +27,9 @@ client_run_dev: | |||
| cd client && \ | |||
| yarn start | |||
| client_run: client_run_dev | |||
|
|
|||
| client_test: | |||
There was a problem hiding this comment.
Hi Erin! Congrats on your first PR! I'm wondering what the expected outcome of this make command is. I had to brew install watchman to make this work on my machine, so I'm not sure whether something is wrong with the way our dependencies are working.
Besides that, I wanted to confirm that this would yield the following message:
Press `a` to run all tests, or run Jest with `--watchAll`.
Watch Usage
› Press a to run all tests.
› Press p to filter by a filename regex pattern.
› Press t to filter by a test name regex pattern.
› Press q to quit watch mode.
› Press Enter to trigger a test run.
You press a to run all tests, and then hit q to exit.
Is that right?
There was a problem hiding this comment.
This make target just proxies to the yarn target that was generated by react create app, which is interactive.
There was a problem hiding this comment.
I believe I read that you can force CRA to skip an interactive mode by setting the CI environment variable. This should be set in our actual CI environment (CircleCI), so it shouldn't case any problems there. We'd have to think about whether or not we want the tests to be interactive for other development.
No description provided.