Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR adds a client_test target to the Makefile #26

Merged
merged 1 commit into from
Jan 4, 2018
Merged

This PR adds a client_test target to the Makefile #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ client_run_dev:
cd client && \
yarn start
client_run: client_run_dev

client_test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Erin! Congrats on your first PR! I'm wondering what the expected outcome of this make command is. I had to brew install watchman to make this work on my machine, so I'm not sure whether something is wrong with the way our dependencies are working.

Besides that, I wanted to confirm that this would yield the following message:

Press `a` to run all tests, or run Jest with `--watchAll`.

Watch Usage
 › Press a to run all tests.
 › Press p to filter by a filename regex pattern.
 › Press t to filter by a test name regex pattern.
 › Press q to quit watch mode.
 › Press Enter to trigger a test run.

You press a to run all tests, and then hit q to exit.
Is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make target just proxies to the yarn target that was generated by react create app, which is interactive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I read that you can force CRA to skip an interactive mode by setting the CI environment variable. This should be set in our actual CI environment (CircleCI), so it shouldn't case any problems there. We'd have to think about whether or not we want the tests to be interactive for other development.

facebook/create-react-app#784

cd client && \
yarn test
glide_update:
cd server/src/dp3 && glide update
server_deps:
Expand Down