Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Erin! Congrats on your first PR! I'm wondering what the expected outcome of this make command is. I had to brew install watchman to make this work on my machine, so I'm not sure whether something is wrong with the way our dependencies are working.
Besides that, I wanted to confirm that this would yield the following message:
You press
a
to run all tests, and then hitq
to exit.Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make target just proxies to the yarn target that was generated by
react create app
, which is interactive.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I read that you can force CRA to skip an interactive mode by setting the
CI
environment variable. This should be set in our actual CI environment (CircleCI), so it shouldn't case any problems there. We'd have to think about whether or not we want the tests to be interactive for other development.facebook/create-react-app#784