Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot automerge PRs #2919

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@mkrump
Copy link
Contributor

mkrump commented Nov 4, 2019

Description

Auto merge minor version upgrades initiated by dependabot. Dependabot can automerge updates, but our branch protection will block it, so also add an auto approve GH action to approve dependabot PRs.

@mkrump mkrump requested a review from chrisgilmerproj Nov 4, 2019
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - I really like this update. I guess if we want to ignore specific dependency updates across major versions we either need to pin those deps or add an ignore rule. Which is good to know and I can communicate that to the teams.

@mkrump

This comment has been minimized.

Copy link
Contributor Author

mkrump commented Nov 4, 2019

I guess if we want to ignore specific dependency updates across major versions we either need to pin those deps or add an ignore rule.

Also, if you just close the PR it's supposed to wait until the next update, which is kinda nice b/c you have to continually say you don't want an update.

@mkrump mkrump merged commit 8a06a1d into master Nov 4, 2019
16 checks passed
16 checks passed
Summary no rules match, no planned actions
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the mk-depbot-automerge branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.