Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot automerge PRs #2919

Merged
merged 2 commits into from Nov 4, 2019
Merged

dependabot automerge PRs #2919

merged 2 commits into from Nov 4, 2019

Conversation

mkrump
Copy link
Contributor

@mkrump mkrump commented Nov 4, 2019

Description

Auto merge minor version upgrades initiated by dependabot. Dependabot can automerge updates, but our branch protection will block it, so also add an auto approve GH action to approve dependabot PRs.

Copy link
Contributor

@chrisgilmerproj chrisgilmerproj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 - I really like this update. I guess if we want to ignore specific dependency updates across major versions we either need to pin those deps or add an ignore rule. Which is good to know and I can communicate that to the teams.

@mkrump
Copy link
Contributor Author

mkrump commented Nov 4, 2019

I guess if we want to ignore specific dependency updates across major versions we either need to pin those deps or add an ignore rule.

Also, if you just close the PR it's supposed to wait until the next update, which is kinda nice b/c you have to continually say you don't want an update.

@mkrump mkrump merged commit 8a06a1d into master Nov 4, 2019
@chrisgilmerproj chrisgilmerproj deleted the mk-depbot-automerge branch November 7, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants