Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While assessing #3677 I saw some pretty major structural changes that needed to be addressed. A couple things this does:
/tmp/clamd.sock
. This may increase the time on CircleCI by up to a minute or longer but I think it's a valuable tradeoff.docker inspect
code to work properly since it only returns string values oftrue
orfalse
/etc/clamav/clamd.conf
which causes confusion when folks diagnose problems with this scriptI'm also personally tracking mko-x/docker-clamav#39 which talks about how the software being loaded is an outdated version, which may be the cause of some intermittent flakiness.
Honestly the next time I have to touch this will be to make it a separate repo so I can use it in several places across Transcom's git projects. Hopefully this will keep us stable for a while.
Setup
Try it yourself!