Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mine fix #3

Merged
merged 4 commits into from
May 17, 2017
Merged

Mine fix #3

merged 4 commits into from
May 17, 2017

Conversation

fzzle
Copy link
Contributor

@fzzle fzzle commented Mar 31, 2017

Fixes the notorious frame issues:

  • Picking up seemingly primed mines.
  • No frame set on initialization (unprimed on join).

Copy link
Member

@1bardesign 1bardesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this is the last of it, looks like there was a misunderstanding of the state of the properties on init when joining.

@fzzle
Copy link
Contributor Author

fzzle commented May 16, 2017

@1bardesign, wasn't the first time I fixed it. Somehow the issue found its way back. 😉

@1bardesign 1bardesign merged commit 39b541a into transhumandesign:master May 17, 2017
@fzzle fzzle deleted the mine-fix branch July 14, 2017 20:18
1bardesign pushed a commit that referenced this pull request Dec 12, 2018
furai pushed a commit that referenced this pull request Sep 19, 2019
Harrison-Miller pushed a commit that referenced this pull request May 30, 2020
asumagic pushed a commit that referenced this pull request Dec 21, 2020
asumagic pushed a commit that referenced this pull request Oct 23, 2021
@mugg91 mugg91 mentioned this pull request May 13, 2022
asumagic pushed a commit that referenced this pull request Apr 30, 2023
[dev] Use blobsinbox instead of sector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants