Wrap problematic translations in quotes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbendilas
reviewed
Sep 12, 2017
There was a problem hiding this comment.
@SofiaMargariti what if there is whitespace before the asterisk, ampersand or dash? Shouldn't we enclose the string in quotes in that case as well?
|
@dbendilas good catch! yes we should, I will fix that |
|
@dbendilas it is fixed |
dbendilas
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github markdown header is parsed as yaml document. Characters
:,&,*and-have special meaning in a yaml file so the translations that contain them should be wrapped in double quotes.