Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update gems" #810

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Revert "update gems" #810

merged 1 commit into from
Oct 4, 2016

Conversation

drewda
Copy link
Member

@drewda drewda commented Oct 4, 2016

Reverts #809

was throwing the following error on dev on Sentry

NoMethodErrorconfig/environment.rb in <top (required)> at line 5
errorundefined method `delete_if' for nil:NilClassrake

https://sentry.io/mapzen/datastore-dev/issues/166136381/

@drewda drewda merged commit a7c4fd2 into master Oct 4, 2016
@drewda drewda deleted the revert-809-update-gems branch October 4, 2016 05:47
@drewda drewda removed the in progress label Oct 4, 2016
@drewda drewda self-assigned this Oct 4, 2016
drewda added a commit that referenced this pull request Oct 11, 2016
again after the failure in #809 and #810
drewda added a commit that referenced this pull request Oct 11, 2016
The web dashboard has been internally refactored in SIdekiq 4.2.0. It now uses straight Rack, rather than Rack and Sinatra: https://github.com/mperham/sidekiq/blob/master/Changes.md#420

Removing a hack that was useful in the past but no longer works (and now causes the error that led to having to revert in #810).
@drewda drewda mentioned this pull request Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant