Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems correctly #818

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Update gems correctly #818

merged 2 commits into from
Oct 11, 2016

Conversation

drewda
Copy link
Member

@drewda drewda commented Oct 11, 2016

returning to the failed gem update: #809 and #810

again after the failure in #809 and #810
The web dashboard has been internally refactored in SIdekiq 4.2.0. It now uses straight Rack, rather than Rack and Sinatra: https://github.com/mperham/sidekiq/blob/master/Changes.md#420

Removing a hack that was useful in the past but no longer works (and now causes the error that led to having to revert in #810).
@drewda drewda self-assigned this Oct 11, 2016
@drewda drewda merged commit db68e8b into master Oct 11, 2016
@drewda drewda deleted the update-gems-correctly branch October 11, 2016 22:43
@irees irees mentioned this pull request Oct 13, 2016
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant