Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service clean up #954

Merged
merged 3 commits into from
Feb 8, 2017
Merged

Service clean up #954

merged 3 commits into from
Feb 8, 2017

Conversation

drewda
Copy link
Member

@drewda drewda commented Feb 8, 2017

No description provided.

since we haven't needed either to enforce Ruby style
@codecov-io
Copy link

codecov-io commented Feb 8, 2017

Codecov Report

Merging #954 into master will not impact coverage by -0.5%.

@@            Coverage Diff            @@
##           master     #954     +/-   ##
=========================================
- Coverage   91.44%   90.94%   -0.5%     
=========================================
  Files          99       99             
  Lines        3836     3812     -24     
=========================================
- Hits         3508     3467     -41     
- Misses        328      345     +17
Impacted Files Coverage Δ
app/services/gtfs_graph.rb 89.96% <ø> (-3.75%)
app/models/changeset.rb 88.48% <ø> (-3.4%)
app/controllers/api/v1/routes_controller.rb 86.66% <ø> (ø)
app/serializers/route_serializer.rb 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e240c46...f82263e. Read the comment docs.

@drewda
Copy link
Member Author

drewda commented Feb 8, 2017

FYI, @irees and @doublestranded, just some clean up.

@drewda drewda merged commit 02e8682 into master Feb 8, 2017
@drewda drewda deleted the service-clean-up branch February 8, 2017 00:46
@drewda drewda removed the in progress label Feb 8, 2017
@irees irees mentioned this pull request Feb 16, 2017
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants