Cleanup: use logging.exception()

translate · Oct 22, 2014 · 316f825 · 316f825
1 parent 0499c71
commit 316f825
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/pootle/apps/pootle_app/management/commands/__init__.py b/pootle/apps/pootle_app/management/commands/__init__.py
@@ -60,9 +60,8 @@ def do_translation_project(self, tp, pootle_path, **options):
             logging.info(u"Running %s over %s", self.name, tp)
             try:
                 process_stores = self.handle_translation_project(tp, **options)
-            except Exception as e:
-                logging.error(u"Failed to run %s over %s:\n%s",
-                              self.name, tp, e)
+            except Exception:
+                logging.exception(u"Failed to run %s over %s", self.name, tp)
                 return
 
             if not process_stores:
@@ -72,9 +71,9 @@ def do_translation_project(self, tp, pootle_path, **options):
             logging.info(u"Running %s over %s's files", self.name, tp)
             try:
                 self.handle_all_stores(tp, **options)
-            except Exception as e:
-                logging.error(u"Failed to run %s over %s's files\n%s",
-                              self.name, tp, e)
+            except Exception:
+                logging.exception(u"Failed to run %s over %s's files",
+                                  self.name, tp)
                 return
         elif hasattr(self, "handle_store"):
             store_query = tp.stores.all()
@@ -88,9 +87,9 @@ def do_translation_project(self, tp, pootle_path, **options):
                              self.name, store.pootle_path)
                 try:
                     self.handle_store(store, **options)
-                except Exception as e:
-                    logging.error(u"Failed to run %s over %s:\n%s",
-                                  self.name, store.pootle_path, e)
+                except Exception:
+                    logging.exception(u"Failed to run %s over %s",
+                                      self.name, store.pootle_path)
 
     def handle_noargs(self, **options):
         # adjust debug level to the verbosity option

diff --git a/pootle/apps/pootle_app/management/commands/refresh_stats.py b/pootle/apps/pootle_app/management/commands/refresh_stats.py
@@ -127,8 +127,8 @@ def handle_all(self, **options):
                     prj.refresh_stats(include_children=True)
 
                 self.unregister_refresh_stats()
-            except Exception as e:
-                logging.error(u"Failed to run %s:\n%s", self.name, e)
+            except Exception:
+                logging.exception(u"Failed to run %s", self.name)
         else:
             super(Command, self).handle_all(**options)