Skip to content

Commit

Permalink
chore: use enumerate where applicable
Browse files Browse the repository at this point in the history
  • Loading branch information
nijel committed Feb 6, 2024
1 parent 4c669b0 commit f5b3f0e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions translate/storage/dtd.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,8 @@ def is_valid_entity_name(name):
invalid_amps.append(amppos - 1)
if len(invalid_amps) > 0:
warnings.warn("invalid ampersands in dtd entity %s" % (name))
adjustment = 0
for amppos in invalid_amps:
for adjustment, amppos in enumerate(invalid_amps):
value = value[: amppos - adjustment] + value[amppos - adjustment + 1 :]
adjustment += 1
return value


Expand Down
8 changes: 2 additions & 6 deletions translate/storage/oo.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,13 +417,11 @@ def __init__(self, filename, mode=None, multifilestyle="single"):

def createsubfileindex(self):
"""Reads in all the lines and works out the subfiles."""
linenum = 0
for line in self.multifile:
for linenum, line in enumerate(self.multifile):
subfile = self.getsubfilename(line)
if subfile not in self.subfilelines:
self.subfilelines[subfile] = []
self.subfilelines[subfile].append(linenum)
linenum += 1

def getsubfilename(self, line):
"""Looks up the subfile name for the line."""
Expand Down Expand Up @@ -457,12 +455,10 @@ def getsubfilesrc(self, subfile):
"""Returns the list of lines matching the subfile."""
lines = []
requiredlines = dict.fromkeys(self.subfilelines[subfile])
linenum = 0
self.multifile.seek(0)
for line in self.multifile:
for linenum, line in enumerate(self.multifile):
if linenum in requiredlines:
lines.append(line)
linenum += 1
return "".join(lines)

def openinputfile(self, subfile):
Expand Down

0 comments on commit f5b3f0e

Please sign in to comment.