Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows newline character is sometimes dropped from the end of a string #163

Closed
transl8bzimport opened this issue Nov 14, 2005 · 1 comment

Comments

@transl8bzimport
Copy link

Version: 0.8rc2

Originally posted by David Farning:

running - roundtriptest against 0.8rc4.20051109
against -
firefox 1.0.7 de_DE.xpi

Example:

diff uBwbEir
de-DE.xpi.tmp/chrome/locale/browser/bookmarks/bookmarks.properties
de-DE.xpi.new.tmp/chrome/locale/browser/bookmarks/bookmarks.properties
-
- de-DE.xpi.tmp/chrome/locale/browser/bookmarks/bookmarks.properties
2004-10-18 17:44:51.000000000 -0500
+
de-DE.xpi.new.tmp/chrome/locale/browser/bookmarks/bookmarks.properties
2005-11-11 06:26:22.000000000 -0600
@ -1,16 +1,16 @
newfolder_dialog_title=Neuen Ordner erstellen
cmd_bm_collapsefolder_accesskey=E
cmd_bm_renamebookmark2=Adresse \u00E4ndern…
-cmd_bm_move_undo=R\u00FCckg\u00E4ngig: Lesezeichen verschieben
+cmd_bm_move_undo=R\u00FCckg\u00E4ngig\: Lesezeichen verschieben
cmd_bm_openinnewwindow=In neuem Fenster \u00F6ffnen
BookmarksLivemarkLoading=Dynamisches Lesezeichen wird geladen…
cmd_bm_newseparator_undo_accesskey=R
cmd_delete=L\u00F6schen
-cmd_bm_delete_undo=R\u00FCckg\u00E4ngig: Lesezeichen l\u00F6schen
-EnterExport=Lesezeichendatei exportieren:

I don’t belive that most email clients will show the presences of ^M
(windows return) but if you look at
http://www.rtklib.org/roundtriptests/ff_1.0.7_xpi/de-DE.diff in an
editor such as vi you will see that sometimes the ^M is dropped

thanks
-dtf

@dwaynebailey
Copy link
Member

Not a train smash. I would suggest running the roundtrips to ignore changes in
whitespace (think that will fix the newline issue). It won’t break Mozilla if
we add/remove newlines style.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@dwaynebailey @transl8bzimport and others