Uglifyjs and Uppy

[payner35]

Meteor.js uses https://atmospherejs.com/meteor/standard-minifier-js to create the production build for deployment to a server.

This uses Uglifyjs. I have some productions build issues and I'm pretty sure it's Uppy. (works great in testing env)

I'm not very familiar with uglify but a test has shown the following

any thoughts on this? Can uppy be packaged by Uglify?

[kvz]

It appears it does not understand ES6, seems like you either need to add ES6 support to Uglify, or point it to the ES5 transpiled files vs the ES6 sources?

[goto-bus-stop]

Yep, make sure to use the files from Uppy's lib/ folder—they work with uglify (and are also a bit faster).

[payner35]

the lib folder has dropped off the repo?

just the scr now

[goto-bus-stop]

The lib/ folder is part of the npm package.

[payner35]

so ive been looking into this for a day or so.. and have created 2 packages that work in dev mode (meteor). But still, run into issues when deployed to production. The minification process just hangs

I'm pretty sure the issue is with Uppy. https://github.com/payner35/uppy (maybe there are still some es6 references left here?)

https://github.com/payner35/tus-js-client is working as expected.

[kvz]

What error are you getting now? Still about const? Can we see it? How are you pointing to the lib folder?

[payner35]

ok.. i think I have tracked down the issue. its with

Uppy/lib/plugins/Transloadit/Socket.js

which imports packages socket.io --> engine.io --> ws

ws does not compile with uglify-js and is causing the hang

Any work around?

[arturi]

https://www.npmjs.com/package/ws

Note: This module does not work in the browser. The client in the docs is a reference to a back end with the role of a client in the WebSocket communication. Browser clients must use the native WebSocket object.

So I wonder if it should be in the bundle at all.

[goto-bus-stop]

It shouldn't be, but engine.io-client works on the client and the server, and uses the `browser` field in package.json to differ, just like tus-js-client... This should really be addressed in meteor's build system I'm afraid :/

…

On 23 June 2017 18:39:44 CEST, Artur Paikin ***@***.***> wrote: > Note: This module does not work in the browser. The client in the docs is a reference to a back end with the role of a client in the WebSocket communication. Browser clients must use the native WebSocket object. So I wonder if it should be in the bundle at all. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #230 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[payner35]

yeah.. meteor does have a current issue with the 'browser' field it seems (for now)

Engine.io does indeed have the code that Meteor will ignore

What i have noticed is if I simply delete ws from my node_modules folder..

I can deploy/minify.. and the app works as expected. (with the 2 packages i forked above) I can upload via uppy --> transloadit

So all seems doable for us Meteor folk now.

[kvz]

So all seems doable for us Meteor folk now.

Thanks so much for persevering @payner35, I realize this was a bit rough, but it's is going to help other Meteor users greatly for sure!

[payner35]

no worries. good to have it working ;)