-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard trigger on class names works only on the first instance #326
Comments
@goto-bus-stop potential danger point. introduced to support multiple dashboard open triggers #326 Maybe we should always return an array and just use the first element where multiple elements don’t make sense
Thanks for the suggestion! Also considering this in #328. |
Thanks to you @arturi! |
Seems this one was prematurely closed, but also seems the question is a bit outside of the scope of this issue (tracker) maybe? Perhaps a better place for it would be https://community.transloadit.com/c/uppy? |
@kvz you're right. Opened a question on the community forum: https://community.transloadit.com/t/is-it-possible-to-catch-the-trigger-that-opened-the-dashboard/14547 |
Replied there! |
@arturi do you think that with this update Uppy we'll be able to be triggered also by elements with the right class but added after the initialization of the Dashboard? Or I will need to do something like this with the new element?
|
Yeah, I believe the element has to be on the page on initialization for Uppy to add a listener to it, so your method is the way to go 👍 |
I would like to be able to open the Uppy Dashboard clicking on more than one button, so I tried to use a class instead of an id for the trigger, but it didn't work: only the first button with the choosen class will open the Dashboard.
As a bonus question I'm wondering: can I then get inside uppy which was the button making the call?
The text was updated successfully, but these errors were encountered: