Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppy Angular 17 #4893

Closed
2 tasks done
stephanevallejo opened this issue Jan 25, 2024 · 9 comments
Closed
2 tasks done

Uppy Angular 17 #4893

stephanevallejo opened this issue Jan 25, 2024 · 9 comments
Labels

Comments

@stephanevallejo
Copy link

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

Hello,

When will uppy angular be compatible with angular 17?

Solution

Hello,

When will uppy angular be compatible with angular 17?

Alternatives

Hello,

When will uppy angular be compatible with angular 17?

@gongAll
Copy link

gongAll commented Feb 1, 2024

I believe there is some under the hood code still being refactored, according to this comment by @aduh95. This will probably have to wait. Still, an ETA would be greatly appreciate, in order for devs to be able to make more informed decisions.

@aduh95
Copy link
Member

aduh95 commented Feb 1, 2024

It should be part of the Uppy 4.x release, which we aim to do in Q1 2024. We won't be able to commit to any specific date, as we are in the process of refactoring all Uppy plugins to TypeScript, and it is simply hard to predict how long it's going to take exactly.
Working on Angular in the mean time would be fighting a losing batlle, as Angular is already written in TS but the types in the plugins it consumes are evolving rapidly as the refactor progresses.

@Rahul-codoffer
Copy link

Please Upgrade to Angular 17.x

@aduh95
Copy link
Member

aduh95 commented Mar 20, 2024

It's certainly still on the roadmap, as you can see I've even opened a PR yesterday upgrading the library. The goal would be to release that along with Uppy 4.x which hopefully will be released (at least as beta) in the next few weeks.

Could you give more details on how pressing this is for you? Does the current @uppy/angular release does not work with Angular 17.x?

@Rahul-codoffer
Copy link

@aduh95 no right now i'm unable to install the uppy in my angular 17 project .

Found: @angular/common@17.3.0
npm ERR! node_modules/@angular/common
npm ERR! @angular/common@"^17.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^16.2.0" from @uppy/angular@0.6.1
npm ERR! node_modules/@uppy/angular
npm ERR! @uppy/angular@"*" from the root project

@Murderlon
Copy link
Member

Murderlon commented Mar 20, 2024

Can't we just do this, wouldn't be a breaking change:

"peerDependencies": {
- "@angular/common": "^16.2.0",
- "@angular/core": "^16.2.0",
+ "@angular/common": "^16.2.0 || ^17.0.0",
+ "@angular/core": "^16.2.0 || ^17.0.0",

Even if we upgrade to 17, it would be unnecessary to make this a breaking change to only support 17 if it runs fine on both.

@aduh95
Copy link
Member

aduh95 commented Mar 28, 2024

We've just release @uppy/angular v0.7.0-beta.1, which is built for Angular 17. Don't hesitate to give it a try and report any issue you encounter.

@aduh95 aduh95 closed this as completed Mar 28, 2024
@TiKevin83
Copy link

We've just release @uppy/angular v0.7.0-beta.1, which is built for Angular 17. Don't hesitate to give it a try and report any issue you encounter.

@aduh95 the peer dependencies in v0.7.0-beta.1 still restrict angular to ^16.2.0 - any suggestions or does another release need to be made fixing that for us to use the update with v17?

@aduh95
Copy link
Member

aduh95 commented Apr 11, 2024

@TiKevin83 Thanks for pointing it out. A new beta release is out with the correct peer dependency info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants