Upgrade to Angular 17.x and to TS 5.4 #5008

aduh95 · 2024-03-18T16:24:06Z

Fixes: #4893
Closes: #4869

…hing" This reverts commit f2d3d96.

github-actions · 2024-03-22T14:36:48Z

Diff output files

No diff

...r/projects/uppy/angular/src/lib/components/dashboard-modal/dashboard-modal-demo.component.ts

...ages/@uppy/angular/projects/uppy/angular/src/lib/components/dashboard/dashboard.component.ts

packages/@uppy/core/src/Uppy.ts

socket-security · 2024-03-27T10:27:51Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

aduh95 · 2024-03-27T12:03:17Z

examples/angular-example/package.json

    "@uppy/angular": "workspace:*",
    "@uppy/core": "workspace:*",
    "@uppy/drag-drop": "workspace:*",
    "@uppy/google-drive": "workspace:*",
    "@uppy/progress-bar": "workspace:*",
    "@uppy/tus": "workspace:*",
+    "@uppy/utils": "workspace:*",


We should remove that somehow, it's not recommended for consumers of Uppy plugins should not depend on @uppy/utils, which is supposed to be internal only.

Murderlon · 2024-03-28T08:51:49Z

examples/angular-example/src/app/app.component.ts

@@ -65,7 +66,7 @@ export class AppComponent implements OnInit {
    },
  }

-  uppy: Uppy = new Uppy({ debug: true, autoProceed: true })
+  uppy: Uppy<Meta, Body> = new Uppy({ debug: true, autoProceed: true })


This doesn't do it for now?

Suggested change

uppy: Uppy<Meta, Body> = new Uppy({ debug: true, autoProceed: true })

uppy: Uppy<any, any> = new Uppy({ debug: true, autoProceed: true })

Yeah, it forces us to silence the no-explicit-any rule – and I wouldn't be surprised if some users prefer to depend on @uppy/utils rather than use any – but it's probably better for now.

* 4.x: @uppy/angular,meta: upgrade to Angular 17.x and to TS 5.4 (#5008) @uppy/svelte: remove UMD output and make it use newer types (#5023) fix type imports (#5038) @uppy/aws-s3-multipart: mark `opts` as optional (#5039) e2e: bump Cypress version (#5034) @uppy/react: remove `prop-types` dependency (#5031) @uppy/progress-bar: remove default target (#4971) @uppy/status-bar: remove default target (#4970) @uppy/react: remove `Wrapper.ts` (#5032) @uppy/react: refactor to TS (#5012) @uppy/core: refine type of private variables (#5028) @uppy/dashboard: refine type of private variables (#5027) @uppy/drag-drop: refine type of private variables (#5026) @uppy/status-bar: refine type of private variables (#5025)

| Package | Version | Package | Version | | ------------------------- | ------------ | ------------------------- | ------------ | | @uppy/angular | 0.7.0-beta.1 | @uppy/progress-bar | 4.0.0-beta.1 | | @uppy/audio | 2.0.0-beta.1 | @uppy/provider-views | 4.0.0-beta.1 | | @uppy/aws-s3 | 4.0.0-beta.1 | @uppy/react | 4.0.0-beta.1 | | @uppy/aws-s3-multipart | 4.0.0-beta.1 | @uppy/redux-dev-tools | 4.0.0-beta.1 | | @uppy/box | 3.0.0-beta.1 | @uppy/remote-sources | 2.0.0-beta.1 | | @uppy/companion | 5.0.0-beta.1 | @uppy/screen-capture | 4.0.0-beta.1 | | @uppy/companion-client | 4.0.0-beta.1 | @uppy/status-bar | 4.0.0-beta.1 | | @uppy/compressor | 2.0.0-beta.1 | @uppy/store-default | 4.0.0-beta.1 | | @uppy/core | 4.0.0-beta.1 | @uppy/store-redux | 4.0.0-beta.1 | | @uppy/dashboard | 4.0.0-beta.1 | @uppy/svelte | 4.0.0-beta.1 | | @uppy/drag-drop | 4.0.0-beta.1 | @uppy/thumbnail-generator | 4.0.0-beta.1 | | @uppy/drop-target | 3.0.0-beta.1 | @uppy/transloadit | 4.0.0-beta.1 | | @uppy/dropbox | 4.0.0-beta.1 | @uppy/tus | 4.0.0-beta.1 | | @uppy/facebook | 4.0.0-beta.1 | @uppy/unsplash | 4.0.0-beta.1 | | @uppy/file-input | 4.0.0-beta.1 | @uppy/url | 4.0.0-beta.1 | | @uppy/form | 4.0.0-beta.1 | @uppy/utils | 6.0.0-beta.1 | | @uppy/golden-retriever | 4.0.0-beta.1 | @uppy/vue | 2.0.0-beta.1 | | @uppy/google-drive | 4.0.0-beta.1 | @uppy/webcam | 4.0.0-beta.1 | | @uppy/image-editor | 3.0.0-beta.1 | @uppy/xhr-upload | 4.0.0-beta.1 | | @uppy/informer | 4.0.0-beta.1 | @uppy/zoom | 3.0.0-beta.1 | | @uppy/instagram | 4.0.0-beta.1 | uppy | 4.0.0-beta.1 | | @uppy/onedrive | 4.0.0-beta.1 | | | - @uppy/vue: migrate to Composition API with TS & drop Vue 2 support (Merlijn Vos / #5043) - @uppy/angular: upgrade to Angular 17.x and to TS 5.4 (Antoine du Hamel / #5008) - @uppy/svelte: remove UMD output and make it use newer types (Antoine du Hamel / #5023) - @uppy/companion-client,@uppy/provider-views,@uppy/status-bar: fix type imports (Antoine du Hamel / #5038) - @uppy/aws-s3-multipart: mark `opts` as optional (Antoine du Hamel / #5039) - e2e: bump Cypress version (Antoine du Hamel / #5034) - @uppy/react: remove `prop-types` dependency (Antoine du Hamel / #5031) - @uppy/progress-bar: remove default target (Antoine du Hamel / #4971) - @uppy/status-bar: remove default target (Antoine du Hamel / #4970) - @uppy/react: remove `Wrapper.ts` (Antoine du Hamel / #5032) - @uppy/react: refactor to TS (Antoine du Hamel / #5012) - @uppy/core: refine type of private variables (Antoine du Hamel / #5028) - @uppy/dashboard: refine type of private variables (Antoine du Hamel / #5027) - @uppy/drag-drop: refine type of private variables (Antoine du Hamel / #5026) - @uppy/status-bar: refine type of private variables (Antoine du Hamel / #5025) - @uppy/remote-sources: migrate to TS (Merlijn Vos / #5020) - @uppy/dashboard: refine option types (Antoine du Hamel / #5022) - @uppy/dashboard: add new `autoOpen` option (Chris Grigg / #5001) - @uppy/aws-s3-multipart,@uppy/tus,@uppy/utils,@uppy/xhr-upload: Make `allowedMetaFields` consistent (Merlijn Vos / #5011) - @uppy/core: fix some type errors (Antoine du Hamel / #5015) - @uppy/audio,@uppy/dashboard,@uppy/drop-target,@uppy/webcam: add missing exports (Antoine du Hamel / #5014) - meta: Bump webpack-dev-middleware from 5.3.3 to 5.3.4 (dependabot[bot] / #5013) - @uppy/dashboard: refactor to TypeScript (Antoine du Hamel / #4984) - @uppy/companion: improve error msg (Mikael Finstad / #5010) - @uppy/aws-s3-multipart: refactor to TS (Antoine du Hamel / #4902) - @uppy/dashboard: refactor to stable lifecycle method (Antoine du Hamel / #4999) - @uppy/companion: crash if trying to set path to / (Mikael Finstad / #5003) - @uppy/provider-views: fix `super.toggleCheckbox` bug (Mikael Finstad / #5004) - @uppy/aws-s3-multipart: fix escaping issue with client signed request (Hiroki Shimizu / #5006) - @uppy/drag-drop,@uppy/progress-bar: add missing exports (Antoine du Hamel / #5009) - @uppy/transloadit: migrate to TS (Merlijn Vos / #4987) - @uppy/utils: fix `RateLimitedQueue#wrapPromiseFunction` types (Antoine du Hamel / #5007) - @uppy/golden-retriever: migrate to TS (Merlijn Vos / #4989) - meta: Bump follow-redirects from 1.15.4 to 1.15.6 (dependabot[bot] / #5002) - meta: fix `resize-observer-polyfill` types (Antoine du Hamel / #4994) - @uppy/core: various type fixes (Antoine du Hamel / #4995) - @uppy/utils: fix `findAllDOMElements` type (Antoine du Hamel / #4997) - @uppy/status-bar: fix `recoveredState` type (Antoine du Hamel / #4996) - @uppy/utils: fix `AbortablePromise` type (Antoine du Hamel / #4988) - @uppy/core,@uppy/provider-views: Fix breadcrumbs (Evgenia Karunus / #4986) - @uppy/drag-drop: refactor to TypeScript (Antoine du Hamel / #4983) - @uppy/webcam: refactor to TypeScript (Antoine du Hamel / #4870) - @uppy/url: migrate to TS (Merlijn Vos / #4980) - @uppy/zoom: refactor to TypeScript (Murderlon / #4979) - @uppy/unsplash: refactor to TypeScript (Murderlon / #4979) - @uppy/onedrive: refactor to TypeScript (Murderlon / #4979) - @uppy/instagram: refactor to TypeScript (Murderlon / #4979) - @uppy/google-drive: refactor to TypeScript (Murderlon / #4979) - @uppy/facebook: refactor to TypeScript (Murderlon / #4979) - @uppy/dropbox: refactor to TypeScript (Murderlon / #4979) - @uppy/box: refactor to TypeScript (Murderlon / #4979) - @uppy/utils: migrate RateLimitedQueue to TS (Merlijn Vos / #4981) - @uppy/thumbnail-generator: migrate to TS (Merlijn Vos / #4978) - @uppy/screen-capture: migrate to TS (Merlijn Vos / #4965) - @uppy/companion-client: Replace Provider.initPlugin with composition (Merlijn Vos / #4977) - uppy: remove legacy bundle (Antoine du Hamel) - meta: include types in npm archive (Antoine du Hamel) - @uppy/angular: fix build (Antoine du Hamel) - meta: Remove generate types from locale-pack (Murderlon) - meta: enable CI on `4.x` branch (Antoine du Hamel) - @uppy/vue: [v4.x] remove manual types (Antoine du Hamel / #4803) - meta: prepare release workflow for beta versions (Antoine du Hamel) | Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/audio | 1.1.8 | @uppy/progress-bar | 3.1.1 | | @uppy/aws-s3-multipart | 3.11.0 | @uppy/provider-views | 3.11.0 | | @uppy/box | 2.3.0 | @uppy/react | 3.3.0 | | @uppy/companion | 4.13.0 | @uppy/remote-sources | 1.2.0 | | @uppy/companion-client | 3.8.0 | @uppy/screen-capture | 3.2.0 | | @uppy/compressor | 1.1.2 | @uppy/status-bar | 3.3.1 | | @uppy/core | 3.10.0 | @uppy/thumbnail-generator | 3.1.0 | | @uppy/dashboard | 3.8.0 | @uppy/transloadit | 3.6.0 | | @uppy/drag-drop | 3.1.0 | @uppy/tus | 3.5.4 | | @uppy/drop-target | 2.0.5 | @uppy/unsplash | 3.3.0 | | @uppy/dropbox | 3.3.0 | @uppy/url | 3.6.0 | | @uppy/facebook | 3.3.0 | @uppy/utils | 5.7.5 | | @uppy/golden-retriever | 3.2.0 | @uppy/webcam | 3.4.0 | | @uppy/google-drive | 3.5.0 | @uppy/zoom | 2.3.0 | | @uppy/instagram | 3.3.0 | uppy | 3.24.0 | | @uppy/onedrive | 3.3.0 | | | - @uppy/box,@uppy/companion-client,@uppy/provider-views,@uppy/status-bar: fix type imports (Antoine du Hamel / #5038) - @uppy/aws-s3-multipart: mark `opts` as optional (Antoine du Hamel / #5039) - e2e: bump Cypress version (Antoine du Hamel / #5034) - @uppy/react: refactor to TS (Antoine du Hamel / #5012) - @uppy/core: refine type of private variables (Antoine du Hamel / #5028) - @uppy/dashboard: refine type of private variables (Antoine du Hamel / #5027) - @uppy/drag-drop: refine type of private variables (Antoine du Hamel / #5026) - @uppy/status-bar: refine type of private variables (Antoine du Hamel / #5025) - @uppy/remote-sources: migrate to TS (Merlijn Vos / #5020) - @uppy/dashboard: refine option types (Antoine du Hamel / #5022) - @uppy/dashboard: add new `autoOpen` option (Chris Grigg / #5001) - @uppy/core: fix some type errors (Antoine du Hamel / #5015) - @uppy/audio,@uppy/dashboard,@uppy/drop-target,@uppy/webcam: add missing exports (Antoine du Hamel / #5014) - meta: Bump webpack-dev-middleware from 5.3.3 to 5.3.4 (dependabot[bot] / #5013) - @uppy/dashboard: refactor to TypeScript (Antoine du Hamel / #4984) - @uppy/companion: improve error msg (Mikael Finstad / #5010) - @uppy/aws-s3-multipart: refactor to TS (Antoine du Hamel / #4902) - @uppy/dashboard: refactor to stable lifecycle method (Antoine du Hamel / #4999) - @uppy/companion: crash if trying to set path to / (Mikael Finstad / #5003) - @uppy/provider-views: fix `super.toggleCheckbox` bug (Mikael Finstad / #5004) - @uppy/aws-s3-multipart: fix escaping issue with client signed request (Hiroki Shimizu / #5006) - @uppy/drag-drop,@uppy/progress-bar: add missing exports (Antoine du Hamel / #5009) - @uppy/transloadit: migrate to TS (Merlijn Vos / #4987) - @uppy/utils: fix `RateLimitedQueue#wrapPromiseFunction` types (Antoine du Hamel / #5007) - @uppy/golden-retriever: migrate to TS (Merlijn Vos / #4989) - meta: Bump follow-redirects from 1.15.4 to 1.15.6 (dependabot[bot] / #5002) - meta: fix `resize-observer-polyfill` types (Antoine du Hamel / #4994) - @uppy/core: various type fixes (Antoine du Hamel / #4995) - @uppy/utils: fix `findAllDOMElements` type (Antoine du Hamel / #4997) - @uppy/status-bar: fix `recoveredState` type (Antoine du Hamel / #4996) - @uppy/utils: fix `AbortablePromise` type (Antoine du Hamel / #4988) - @uppy/core,@uppy/provider-views: Fix breadcrumbs (Evgenia Karunus / #4986) - @uppy/drag-drop: refactor to TypeScript (Antoine du Hamel / #4983) - @uppy/webcam: refactor to TypeScript (Antoine du Hamel / #4870) - @uppy/url: migrate to TS (Merlijn Vos / #4980) - @uppy/zoom: refactor to TypeScript (Murderlon / #4979) - @uppy/unsplash: refactor to TypeScript (Murderlon / #4979) - @uppy/onedrive: refactor to TypeScript (Murderlon / #4979) - @uppy/instagram: refactor to TypeScript (Murderlon / #4979) - @uppy/google-drive: refactor to TypeScript (Murderlon / #4979) - @uppy/facebook: refactor to TypeScript (Murderlon / #4979) - @uppy/dropbox: refactor to TypeScript (Murderlon / #4979) - @uppy/box: refactor to TypeScript (Murderlon / #4979) - @uppy/utils: migrate RateLimitedQueue to TS (Merlijn Vos / #4981) - @uppy/thumbnail-generator: migrate to TS (Merlijn Vos / #4978) - @uppy/screen-capture: migrate to TS (Merlijn Vos / #4965) - @uppy/companion-client: Replace Provider.initPlugin with composition (Merlijn Vos / #4977)

* 4.x: (27 commits) Release: uppy@4.0.0-beta.1 (#5047) @uppy/vue: migrate to Composition API with TS & drop Vue 2 support (#5043) @uppy/angular,meta: upgrade to Angular 17.x and to TS 5.4 (#5008) @uppy/svelte: remove UMD output and make it use newer types (#5023) fix type imports (#5038) @uppy/aws-s3-multipart: mark `opts` as optional (#5039) e2e: bump Cypress version (#5034) @uppy/react: remove `prop-types` dependency (#5031) @uppy/progress-bar: remove default target (#4971) @uppy/status-bar: remove default target (#4970) @uppy/react: remove `Wrapper.ts` (#5032) @uppy/react: refactor to TS (#5012) @uppy/core: refine type of private variables (#5028) @uppy/dashboard: refine type of private variables (#5027) @uppy/drag-drop: refine type of private variables (#5026) @uppy/status-bar: refine type of private variables (#5025) @uppy/remote-sources: migrate to TS (#5020) @uppy/dashboard: refine option types (#5022) @uppy/dashboard: add new `autoOpen` option (#5001) Make `allowedMetaFields` consistent (#5011) ...

aduh95 added the 4.0 For the 4.0 major version label Mar 18, 2024

aduh95 mentioned this pull request Mar 19, 2024

fix super.toggleCheckbox bug #5004

Merged

Murderlon mentioned this pull request Mar 19, 2024

Uppy 4.0 major, motherissue #4764

Open

35 tasks

aduh95 mentioned this pull request Mar 20, 2024

@uppy/angular: fix TS build errors #4829

Closed

aduh95 added 6 commits March 22, 2024 15:17

@uppy/angular: upgrade to Angular 17

38ed9bb

Revert "meta: remove @uppy/angular build while we are typing everyt…

ce71e57

…hing" This reverts commit f2d3d96.

upgrade TS

3acfa80

fixup! upgrade TS

d6d72d7

fix types in angular files

6d5cb28

w

3308685

aduh95 force-pushed the upgrade-angular branch from 7181e8d to 3308685 Compare March 22, 2024 14:35

aduh95 and others added 6 commits March 22, 2024 16:06

@uppy/core: fix some type errors

c0954da

w

85dc6f0

@ts-ignore

4bfb776

add missing exports (#5014)

11d8434

f

7168c10

prettier

f1d5db9

This comment was marked as off-topic.

Sign in to view

Merge branch '4.x' of https://github.com/transloadit/uppy

ef686ee

aduh95 commented Mar 27, 2024

View reviewed changes

...r/projects/uppy/angular/src/lib/components/dashboard-modal/dashboard-modal-demo.component.ts Outdated Show resolved Hide resolved

aduh95 commented Mar 27, 2024

View reviewed changes

...ages/@uppy/angular/projects/uppy/angular/src/lib/components/dashboard/dashboard.component.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

3fd062e

aduh95 commented Mar 27, 2024

View reviewed changes

packages/@uppy/core/src/Uppy.ts Outdated Show resolved Hide resolved

aduh95 marked this pull request as ready for review March 27, 2024 10:26

aduh95 added 2 commits March 27, 2024 12:08

fix example

fc534d4

fix example

12762fa

aduh95 commented Mar 27, 2024

View reviewed changes

Merge branch '4.x' of https://github.com/transloadit/uppy

815ab39

revert unrelated changes

8398740

aduh95 requested a review from Murderlon March 27, 2024 13:50

Murderlon approved these changes Mar 28, 2024

View reviewed changes

aduh95 added 2 commits March 28, 2024 09:58

remove @uppy/utils deps

0100fdf

Merge branch '4.x' of https://github.com/transloadit/uppy

f33af4f

aduh95 merged commit 4f91a0d into 4.x Mar 28, 2024
20 checks passed

aduh95 deleted the upgrade-angular branch March 28, 2024 09:10

github-actions bot mentioned this pull request Mar 28, 2024

Release: uppy@4.0.0-beta.1 #5041

Closed

aduh95 mentioned this pull request Mar 28, 2024

Update to angular 17 #4869

Closed

github-actions bot mentioned this pull request Mar 28, 2024

Release: uppy@4.0.0-beta.1 #5047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Angular 17.x and to TS 5.4 #5008

Upgrade to Angular 17.x and to TS 5.4 #5008

aduh95 commented Mar 18, 2024 •

edited

github-actions bot commented Mar 22, 2024 •

edited

This comment was marked as off-topic.

socket-security bot commented Mar 27, 2024 •

edited

aduh95 Mar 27, 2024

Murderlon Mar 28, 2024

aduh95 Mar 28, 2024

	uppy: Uppy<Meta, Body> = new Uppy({ debug: true, autoProceed: true })
	uppy: Uppy<any, any> = new Uppy({ debug: true, autoProceed: true })

Upgrade to Angular 17.x and to TS 5.4 #5008

Upgrade to Angular 17.x and to TS 5.4 #5008

Conversation

aduh95 commented Mar 18, 2024 • edited

github-actions bot commented Mar 22, 2024 • edited

This comment was marked as off-topic.

socket-security bot commented Mar 27, 2024 • edited

aduh95 Mar 27, 2024

Choose a reason for hiding this comment

Murderlon Mar 28, 2024

Choose a reason for hiding this comment

aduh95 Mar 28, 2024

Choose a reason for hiding this comment

aduh95 commented Mar 18, 2024 •

edited

github-actions bot commented Mar 22, 2024 •

edited

socket-security bot commented Mar 27, 2024 •

edited