YMPT™: Yet More Progress Tweaks #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally broken in #1093
arturi
reviewed
Mar 26, 2019
| @@ -27,14 +27,14 @@ Object { | |||
| "name": "foo.jpg", | |||
| "preview": undefined, | |||
| "progress": Object { | |||
| "bytesTotal": 0, | |||
| "bytesTotal": null, | |||
| "bytesUploaded": 0, | |||
| "percentage": 0, | |||
There was a problem hiding this comment.
Should all those be null then? Otherwise bytesTotal is null, but bytesUploaded is 0?
There was a problem hiding this comment.
I only changed bytesTotal because bytesUploaded: 0 is actually accurate, we did upload precisely 0 bytes, while bytesTotal: 0 was a lie (we don't know if the file is 0 bytes)
|
Thanks for attacking this! Crazy we didn’t have file sizes by accident for a while. |
|
I’ve gotten this:
and other weird |
Merged
This was referenced May 26, 2021
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
YMPT™: Yet More Progress Tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1093 accidentally omitted file size reporting for GDrive/Dropbox uploads, which threw off client-side progress reporting. The first commit adds it back.
Unsized files (like instagram photos) now are stored with
size: nullinstead of 0. Progress calculations usedbytesTotal == nullto check for unsized files, so this aligns the two properties. It also makes sure that unsized and 0-byte files are treated differently. Unsized files mean "this may be any size, we don't know" while empty files are just empty and we know it.We've had several PRs to this stuff now so it needs more tests to avoid breakage in the future. Opening as a draft PR now so the … progress … is visible.