Migrate provider adapter to Companion #1093
Conversation
ifedapoolarewaju
requested review from
arturi and
goto-bus-stop
and removed request for
arturi
|
5KB is not bad at all 🎉 Excited for this! looks good on first glance, will test it in a bit 👍 |
| thumbnail: uppy.buildURL(adapter.getItemThumbnailUrl(item), true), | ||
| requestPath: adapter.getItemRequestPath(item), | ||
| modifiedDate: adapter.getItemModifiedDate(item), | ||
| raw: item |
There was a problem hiding this comment.
It looks like raw is only used for team drive detection. Could we also do that on the server side instead and add an isTeamDrive property to GDrive items? So we don't send unnecessary data to the client.
There was a problem hiding this comment.
nice! I guess I was restricting myself from sending varying properties per Provider. But I think what I can do is something like this:
custom: {
isTeamDrive: true
}so all custom properties per provider can live there
There was a problem hiding this comment.
👍 That looks good to me too
There was a problem hiding this comment.
updated this now
| @@ -0,0 +1,66 @@ | |||
| exports.getUsername = (data) => { | |||
There was a problem hiding this comment.
Can we find the username somehow even if there are no files?
| @@ -0,0 +1,66 @@ | |||
| exports.getUsername = (data) => { | |||
There was a problem hiding this comment.
Perhaps in the future we can grab the username during authentication and store it in the JWT 🤔
| @@ -0,0 +1,73 @@ | |||
| exports.getUsername = (data) => { | |||
| return data.data[0].user.username | |||
There was a problem hiding this comment.
Should only do this if data.data[0] actually exists, in case there are no files
|
Tested, works for me! Happy about moving this to the server, not only for 5KB, but for consistency and simpler new integrations, like React Native. Would be nice to add a common API response example — what a general client provider should expect to get from the server. Or maybe do this for each provider somewhere, shape of the object with all the files and folders, and their properties. |
|
Maybe we can merge this today with the Instagram username fix (#1093 (comment)) and then do the docs later. Would be nice to get this in 0.28 Client/0.15 Companion |
This was accidentally broken in #1093
…-adapter Migrate provider adapter to Companion
This was accidentally broken in transloadit#1093
saves us 5KB on the frontend. Not much but it's something 🙂
Fixes #1083