typescript: fix uppy package use with allowSyntheticImports: false #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthetic default imports allow you to `import X from 'x'` if `'x'` is a CommonJS module. Our `uppy` package relied on that (probably forgot to update it in a previous patch). If users had set `allowSyntheticDefaultImports: false`, they would not be able to use the `uppy` package. We should at some point go through the typings again and set everything to the tightest options, because that'll work with the widest array of users, but for now let's just unbreak this particular case. Fixes #1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthetic default imports allow you to
import X from 'x'if'x'is aCommonJS module. Our
uppypackage relied on that (probably forgot toupdate it in a previous patch). If users had set
allowSyntheticDefaultImports: false, they would not be able to use theuppypackage.We should at some point go through the typings again and set everything to
the tightest options, because that'll work with the widest array of users,
but for now let's just unbreak this particular case.
Fixes #1395