Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Log versions of Uppy plugins for debugging #1640

Merged
merged 3 commits into from
Jun 12, 2019
Merged

core: Log versions of Uppy plugins for debugging #1640

merged 3 commits into from
Jun 12, 2019

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Jun 6, 2019 •
edited
Loading

After #1600, we have .VERSIONS property on all plugins.

With this PR, Uppy produces the following log:

[Uppy] [17:00:07] Using Core v1.1.0
[Uppy] [17:00:07] Using Dashboard v1.1.0
[Uppy] [17:00:07] Installing Dashboard to a DOM element
[Uppy] [17:00:07] Using Dashboard:StatusBar v1.1.0
[Uppy] [17:00:07] Installing Dashboard:StatusBar to Dashboard
[Uppy] [17:00:07] Using Dashboard:Informer v1.1.0
[Uppy] [17:00:07] Installing Dashboard:Informer to Dashboard
[Uppy] [17:00:07] Using Dashboard:ThumbnailGenerator v1.1.0
[Uppy] [17:00:07] Using GoogleDrive v1.1.0
[Uppy] [17:00:07] Installing GoogleDrive to Dashboard
[Uppy] [17:00:07] Using Instagram v1.1.0
[Uppy] [17:00:07] Installing Instagram to Dashboard
[Uppy] [17:00:07] Using Dropbox v1.1.0
[Uppy] [17:00:07] Installing Dropbox to Dashboard
[Uppy] [17:00:07] Using Url v1.1.0
[Uppy] [17:00:07] Installing Url to Dashboard
[Uppy] [17:00:07] Using Webcam v1.1.0
[Uppy] [17:00:07] Installing Webcam to Dashboard
[Uppy] [17:00:07] Using Tus v1.1.0
[Uppy] [17:00:07] Using Form v1.1.0

@arturi arturi changed the title Log versions of Uppy plugins for debugging core: Log versions of Uppy plugins for debugging Jun 6, 2019
@arturi arturi requested review from goto-bus-stop and kvz June 6, 2019 16:18
@kvz
Copy link
Member

kvz commented Jun 6, 2019

Very useful this!

@arturi
Copy link
Contributor Author

arturi commented Jun 6, 2019

In Core I do this.constructor.VERSION to access VERSION, could this be the case for some plugins?

@arturi
Copy link
Contributor Author

arturi commented Jun 12, 2019

Updated!

@arturi arturi merged commit 9c2bcc8 into master Jun 12, 2019
@arturi arturi deleted the log-versions branch June 12, 2019 18:04
This was referenced Apr 26, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvz kvz kvz approved these changes

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturi @kvz @goto-bus-stop