Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion: display truer error during oauth failure #1702

Merged
merged 4 commits into from
Jul 10, 2019

Conversation

ifedapoolarewaju
Copy link
Contributor

@ifedapoolarewaju ifedapoolarewaju commented Jun 29, 2019

starting out by displaying the original error. PRs to improve the situation in general may come after.

UPDATE: went ahead to add request IDs so that logs can be traced for a single request. The request ID is returned in the response header so it can be accessed from the client when an error is returned.
so the Oauth error will now look like this:

Companion was unable to complete the OAuth process :(
Error: User session is missing or the Provider was misconfigured
Request ID: acedfbca-782edacf-acedfbca-acedfbca

Also when you receive an error on provider view, it should now look something like this:
Screenshot 2019-06-30 at 12 01 04 PM

Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

we might wanna tweak the detailed error information tooltip to make this a bit easier to read :D Maybe it should be a small modal instead of a hover thing, so it can also be easily copy/pasted. That's a separate PR though!

Copy link
Contributor

@arturi arturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! Tested locally too (although without errors).

@arturi
Copy link
Contributor

arturi commented Jul 5, 2019

Note: this did create a package-lock for Companion for me, likely due to chalk again.

@goto-bus-stop
Copy link
Contributor

Note: this did create a package-lock for Companion for me, likely due to chalk again.

will be fixed when this is merged because of this commit on master:
7282fdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants