companion: display truer error during oauth failure #1702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting out by displaying the original error. PRs to improve the situation in general may come after.
UPDATE: went ahead to add request IDs so that logs can be traced for a single request. The request ID is returned in the response header so it can be accessed from the client when an error is returned.
so the Oauth error will now look like this:
Also when you receive an error on provider view, it should now look something like this: