Google drive shared with me #2758
Conversation
|
I didn't manage to get the tests to work when using the promise version of purest. Something not right with the mocking. See last commit. If you have any pro tip please let me know. |
|
Thanks! This PR works great but I'm not sure that we want this behaviour as is. I was quite surprised by just how many documents I had apparently accessed through links in the past, and it was confusing that they were interspersed with my own files. I think the functionality makes sense, but maybe we'd instead want to show a fake "Shared with me" folder in the root, a bit like how team drives are now? In the https://drive.google.com UI it's also a separate tab. |
# Conflicts: # packages/@uppy/companion/src/server/provider/drive/index.js
|
Have now implemented a virtual "Shared with me" folder in root. The icon doesn't look very coherent with the rest of google drive icons, but it works: Also I'm not sure if we should (or how to) disable the checkbox in front of this virtual directory. If someone chooses all files shared with me by accident, it's potentially gonna be a LOT of files an requests. |
…rive-shared-with-me
|
now even e2e tests are succeeding! |
|
Thank you for the neat feature! |
* Refactor list to use promises * Include shared with me files Fixes transloadit#2739 * revert usage of promise version of purest it fails tests * fix bugs * fix lint warnings * implement shared with me virtual dir * pull out adaptData (it's not a public method, eslint warn) * fix test * disable checkbox for “shared with me” //cc @mifi Co-authored-by: Kevin van Zonneveld <kevin@vanzonneveld.net> Co-authored-by: Artur Paikin <artur@arturpaikin.com>
Fixes #2739
It will now include files that are shared with me (earlier did not because they didn't have
parentsset)I also refactored the function to use async/await for easier reading :)