Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add redis pubsub scope setting #2804

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

coreprocess
Copy link
Contributor

Adds new setting redisPubSubScope which configures the scope parameter at https://www.npmjs.com/package/node-redis-pubsub. Allows one to share a redis instance/cluster with other services more easily.

@arturi arturi requested a review from mifi March 15, 2021 12:48
@arturi
Copy link
Contributor

arturi commented Mar 15, 2021

@mifi could you review, please?

Copy link
Contributor

@mifi mifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goto-bus-stop goto-bus-stop merged commit 6c4f79b into transloadit:master Mar 26, 2021
@coreprocess
Copy link
Contributor Author

Thanks @mifi @arturi @goto-bus-stop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants