Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/companion: fix yarn test command #3590

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Mar 22, 2022

Previously it would throw command not found: jest error
when running yarn workspace @uppy/companion test.

Previously it would throw `command not found: jest` error
when running `yarn workspace @uppy/companion test`.
@aduh95 aduh95 merged commit e80a7f7 into transloadit:main Mar 23, 2022
@aduh95 aduh95 deleted the fix-yarn-test-companion branch March 23, 2022 10:00
@mifi
Copy link
Contributor

mifi commented Mar 23, 2022

Actually without this PR it works with corepack yarn run test:companion which in turn runs yarn workspace @uppy/companion test

dunno why that works while yarn workspace @uppy/companion test doesn't

@github-actions github-actions bot mentioned this pull request Mar 24, 2022
github-actions bot added a commit that referenced this pull request Mar 24, 2022
| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/companion   |   3.5.0 | @uppy/webcam      |   2.1.0 |
| @uppy/status-bar  |   2.1.3 | @uppy/robodog     |   2.5.0 |
| @uppy/transloadit |   2.1.2 | uppy              |   2.9.0 |
| @uppy/tus         |   2.2.1 |                   |         |

- @uppy/transloadit: close assembly if upload is cancelled (Antoine du Hamel / #3591)
- @uppy/companion: Companion server upload events (Mikael Finstad / #3544)
- @uppy/tus: fix double requests sent when rate limiting (Antoine du Hamel / #3595)
- website: fix linter error on blog post (Antoine du Hamel / #3596)
- @uppy/companion: fix `yarn test` command (Antoine du Hamel / #3590)
- @uppy/webcam: Mime types in webcam options type (Sobakin Sviatoslav / #3593)
- website: Some polish and a better (?) intro for the recent update post (AJvanLoon / #3588)
- @uppy/companion: Allow setting no ACL (Mikael Finstad / #3577)
- @uppy/companion: Small companion code and doc changes (Mikael Finstad / #3586)
- @uppy/robodog: fix CDN bundle (Antoine du Hamel / #3587)
- website: Fix broken link (YukeshShr / #3581)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
Previously it would throw `command not found: jest` error
when running `yarn workspace @uppy/companion test`.
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/companion   |   3.5.0 | @uppy/webcam      |   2.1.0 |
| @uppy/status-bar  |   2.1.3 | @uppy/robodog     |   2.5.0 |
| @uppy/transloadit |   2.1.2 | uppy              |   2.9.0 |
| @uppy/tus         |   2.2.1 |                   |         |

- @uppy/transloadit: close assembly if upload is cancelled (Antoine du Hamel / transloadit#3591)
- @uppy/companion: Companion server upload events (Mikael Finstad / transloadit#3544)
- @uppy/tus: fix double requests sent when rate limiting (Antoine du Hamel / transloadit#3595)
- website: fix linter error on blog post (Antoine du Hamel / transloadit#3596)
- @uppy/companion: fix `yarn test` command (Antoine du Hamel / transloadit#3590)
- @uppy/webcam: Mime types in webcam options type (Sobakin Sviatoslav / transloadit#3593)
- website: Some polish and a better (?) intro for the recent update post (AJvanLoon / transloadit#3588)
- @uppy/companion: Allow setting no ACL (Mikael Finstad / transloadit#3577)
- @uppy/companion: Small companion code and doc changes (Mikael Finstad / transloadit#3586)
- @uppy/robodog: fix CDN bundle (Antoine du Hamel / transloadit#3587)
- website: Fix broken link (YukeshShr / transloadit#3581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants