Propagate isNetworkError through error wrappers
#3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ErrorWithCause` class uses the same signature as the builtin Error
does, but it supports the `{ cause }` option in older environments, and
it propagates the `isNetworkError` property from the underlying error.
Murderlon
approved these changes
Apr 5, 2022
aduh95
approved these changes
Apr 5, 2022
Merged
github-actions bot
added a commit
that referenced
this pull request
Apr 7, 2022
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3 | 2.0.9 | @uppy/utils | 4.0.6 | | @uppy/companion-client | 2.0.6 | @uppy/robodog | 2.5.2 | | @uppy/compressor | 0.2.4 | uppy | 2.9.2 | | @uppy/transloadit | 2.1.4 | | | - @uppy/aws-s3,@uppy/companion-client,@uppy/transloadit,@uppy/utils: Propagate `isNetworkError` through error wrappers (Renée Kooi / #3620) - @uppy/compressor: Merge new name and type into compressed file (Camilo Forero / #3606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ErrorWithCauseclass uses the same signature as the builtin Errordoes, but it supports the
{ cause }option in older environments, andit propagates the
isNetworkErrorproperty from the underlying error.