Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/core: fix TypeError in event handler when file was removed #3629

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Apr 7, 2022

This would deserve a test, but it would be nice to land it sooner rather than later.

@aduh95 aduh95 requested a review from Murderlon April 7, 2022 15:20
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can file also be undefined? Might be good to catch both?

@aduh95
Copy link
Member Author

aduh95 commented Apr 7, 2022

Can file also be undefined? Might be good to catch both?

== null catches both null and undefined (and document.all), so we should be good

@Murderlon
Copy link
Member

== null catch both null and undefined (and document.all), so we should be good

Surprised I didn't know this 😮

@aduh95 aduh95 merged commit cf749be into main Apr 7, 2022
@aduh95 aduh95 deleted the fix-typeerror-event-handler branch April 7, 2022 17:24
@github-actions github-actions bot mentioned this pull request Apr 7, 2022
github-actions bot added a commit that referenced this pull request Apr 7, 2022
| Package       | Version | Package       | Version |
| ------------- | ------- | ------------- | ------- |
| @uppy/core    |   2.1.8 | uppy          |   2.9.3 |
| @uppy/robodog |   2.5.3 |               |         |

- @uppy/core: fix TypeError in event handler when file was removed (Antoine du Hamel / #3629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants