Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/drop-target: refactor to ESM #3648

Merged
merged 2 commits into from
Apr 20, 2022
Merged

@uppy/drop-target: refactor to ESM #3648

merged 2 commits into from
Apr 20, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Apr 20, 2022

No description provided.

Murderlon
Murderlon reviewed Apr 20, 2022
View reviewed changes
packages/@uppy/drop-target/src/index.js
module.exports = class DropTarget extends BasePlugin {
static VERSION = require('../package.json').version
export default class DropTarget extends BasePlugin {
static VERSION = packageJson.version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might break the babel plugin, might be good to check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recreated that plugin in the build-lib script:

uppy/bin/build-lib.js

Lines 111 to 124 in 2a4e2bf

if (PACKAGE_JSON_IMPORT.test(value)
&& path.node.specifiers.length === 1
&& path.node.specifiers[0].type === 'ImportDefaultSpecifier') {
// Vendor-in version number from package.json files:
const version = versionCache.get(file.slice(0, file.indexOf('/src/')))
if (version != null) {
const [{ local }] = path.node.specifiers
path.replaceWith(
t.variableDeclaration('const', [t.variableDeclarator(local,
t.objectExpression([
t.objectProperty(t.stringLiteral('version'), t.stringLiteral(version)),
]))]),
)
}

@aduh95 aduh95 merged commit 305f0d8 into main Apr 20, 2022
@aduh95 aduh95 deleted the drop-target-esm branch April 20, 2022 13:19
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Merged
github-actions bot added a commit that referenced this pull request Apr 27, 2022
@github-actions
Release: uppy@2.9.4 (#3667)
2289fc9 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/aws-s3-multipart |   2.2.2 | @uppy/file-input       |   2.0.6 |
| @uppy/box              |   1.0.6 | @uppy/form             |   2.0.5 |
| @uppy/companion        |   3.5.1 | @uppy/locales          |   2.0.9 |
| @uppy/compressor       |   0.2.5 | @uppy/transloadit      |   2.1.5 |
| @uppy/core             |   2.1.9 | @uppy/utils            |   4.0.7 |
| @uppy/drag-drop        |   2.0.7 | @uppy/vue              |   0.4.7 |
| @uppy/drop-target      |   1.1.3 | @uppy/robodog          |   2.5.4 |
| @uppy/dropbox          |   2.0.6 | uppy                   |   2.9.4 |
| @uppy/facebook         |   2.0.6 |                        |         |

- @uppy/locales: Plural translation in cs_CZ local (JakubHaladej / #3666)
- @uppy/vue: Add license field to package.json in @uppy/vue (Tobias Trumm / #3664)
- meta: Add todo comments (Murderlon)
- @uppy/facebook: refactor to ESM (Antoine du Hamel / #3653)
- meta: locale-pack: refactor to use more parallel processing (Antoine du Hamel / #3630)
- @uppy/file-input: refactor to ESM (Antoine du Hamel / #3652)
- meta: sign requests sent to Transloadit in e2e suite (Antoine du Hamel / #3656)
- meta: add `VITE_TRANSLOADIT_SECRET` for e2e (Antoine du Hamel)
- meta: Update BACKLOG.md (Artur Paikin)
- @uppy/form: refactor to ESM (Antoine du Hamel / #3654)
- @uppy/dropbox: refactor to ESM (Antoine du Hamel / #3651)
- meta: sign requests sent to Transloadit in dev env (Antoine du Hamel / #3517)
- @uppy/drop-target: refactor to ESM (Antoine du Hamel / #3648)
- @uppy/core: fix `TypeError` when file was removed (Antoine du Hamel / #3650)
- @uppy/drag-drop: refactor to ESM (Antoine du Hamel / #3647)
- meta: update outdated files (Antoine du Hamel / #3646)
- @uppy/compressor: Set meta on file compression (Camilo Forero / #3644)
- @uppy/transloadit: improve fetch error handling (Antoine du Hamel / #3637)
- @uppy/box: refactor to ESM (Antoine du Hamel / #3643)
- @uppy/utils: Fix getFileType for dicom images (Merlijn Vos / #3610)
- @uppy/aws-s3-multipart: Add `companionCookiesRule` type to @uppy/aws-s3-multipart (Mauricio Ribeiro / #3623)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@github-actions
Release: uppy@2.9.4 (transloadit#3667)
22efb44 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/aws-s3-multipart |   2.2.2 | @uppy/file-input       |   2.0.6 |
| @uppy/box              |   1.0.6 | @uppy/form             |   2.0.5 |
| @uppy/companion        |   3.5.1 | @uppy/locales          |   2.0.9 |
| @uppy/compressor       |   0.2.5 | @uppy/transloadit      |   2.1.5 |
| @uppy/core             |   2.1.9 | @uppy/utils            |   4.0.7 |
| @uppy/drag-drop        |   2.0.7 | @uppy/vue              |   0.4.7 |
| @uppy/drop-target      |   1.1.3 | @uppy/robodog          |   2.5.4 |
| @uppy/dropbox          |   2.0.6 | uppy                   |   2.9.4 |
| @uppy/facebook         |   2.0.6 |                        |         |

- @uppy/locales: Plural translation in cs_CZ local (JakubHaladej / transloadit#3666)
- @uppy/vue: Add license field to package.json in @uppy/vue (Tobias Trumm / transloadit#3664)
- meta: Add todo comments (Murderlon)
- @uppy/facebook: refactor to ESM (Antoine du Hamel / transloadit#3653)
- meta: locale-pack: refactor to use more parallel processing (Antoine du Hamel / transloadit#3630)
- @uppy/file-input: refactor to ESM (Antoine du Hamel / transloadit#3652)
- meta: sign requests sent to Transloadit in e2e suite (Antoine du Hamel / transloadit#3656)
- meta: add `VITE_TRANSLOADIT_SECRET` for e2e (Antoine du Hamel)
- meta: Update BACKLOG.md (Artur Paikin)
- @uppy/form: refactor to ESM (Antoine du Hamel / transloadit#3654)
- @uppy/dropbox: refactor to ESM (Antoine du Hamel / transloadit#3651)
- meta: sign requests sent to Transloadit in dev env (Antoine du Hamel / transloadit#3517)
- @uppy/drop-target: refactor to ESM (Antoine du Hamel / transloadit#3648)
- @uppy/core: fix `TypeError` when file was removed (Antoine du Hamel / transloadit#3650)
- @uppy/drag-drop: refactor to ESM (Antoine du Hamel / transloadit#3647)
- meta: update outdated files (Antoine du Hamel / transloadit#3646)
- @uppy/compressor: Set meta on file compression (Camilo Forero / transloadit#3644)
- @uppy/transloadit: improve fetch error handling (Antoine du Hamel / transloadit#3637)
- @uppy/box: refactor to ESM (Antoine du Hamel / transloadit#3643)
- @uppy/utils: Fix getFileType for dicom images (Merlijn Vos / transloadit#3610)
- @uppy/aws-s3-multipart: Add `companionCookiesRule` type to @uppy/aws-s3-multipart (Mauricio Ribeiro / transloadit#3623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aduh95 @Murderlon