Add @uppy/remote-sources preset/plugin

packages/@uppy/remote-sources/package.json

@@ -43,5 +43,9 @@
   },
   "publishConfig": {
     "access": "public"
+  },
+  "devDependencies": {
+    "@jest/globals": "^28.1.0",
+    "resize-observer-polyfill": "^1.5.1"
   }
 }

packages/@uppy/remote-sources/src/index.js

@@ -48,6 +48,10 @@ export default class RemoteSources extends BasePlugin {
       target: Dashboard,
     }
     this.opts = { ...defaultOptions, ...opts }
+
+    if (this.opts.companionUrl == null) {
+      throw new Error('Please specify companionUrl for RemoteSources to work, see https://uppy.io/docs/remote-sources#companionUrl')
+    }
   }
 
   setOptions (newOpts) {
@@ -60,16 +64,20 @@ export default class RemoteSources extends BasePlugin {
     this.opts.sources.forEach((pluginId) => {
       const optsForRemoteSourcePlugin = { ...this.opts, sources: undefined }
       const plugin = availablePlugins.find(p => p.name === pluginId)
+      if (plugin == null) {
+        const availablePluginsIds = availablePlugins.map(p => p.name)
+        const formatter = new Intl.ListFormat('en', { style: 'long', type: 'disjunction' })
+        throw new Error(`Invalid plugin: "${pluginId}" is not one of: ${formatter.format(availablePluginsIds)}.`)
+      }
       this.uppy.use(plugin, optsForRemoteSourcePlugin)
-      this.#installedPlugins.add(pluginId)
+      this.#installedPlugins.add(plugin)
     })
   }
 
   uninstall () {
-    for (const pluginId of this.#installedPlugins) {
-      const plugin = this.uppy.getPlugin(pluginId)
+    for (const plugin of this.#installedPlugins) {
       this.uppy.removePlugin(plugin)
-      this.#installedPlugins.delete(pluginId)
     }
+    this.#installedPlugins.clear()
   }
 }

packages/@uppy/remote-sources/src/index.test.js

@@ -0,0 +1,42 @@
+import { describe, expect, it } from '@jest/globals'
+import resizeObserverPolyfill from 'resize-observer-polyfill'
+import Core from '@uppy/core'
+import Dashboard from '@uppy/dashboard'
+import RemoteSources from '.'
+
+describe('RemoteSources', () => {
+  beforeAll(() => {
+    globalThis.ResizeObserver = resizeObserverPolyfill.default || resizeObserverPolyfill
+  })
+
+  afterAll(() => {
+    delete globalThis.ResizeObserver
+  })
+
+  it('should install RemoteSources with default options', () => {
+    expect(() => {
+      const core = new Core()
+      core.use(Dashboard)
+      core.use(RemoteSources, { companionUrl: 'https://example.com' })
+    }).not.toThrow()
+  })
+
+  it('should throw when a companionUrl is not specified', () => {
+    expect(() => {
+      const core = new Core()
+      core.use(Dashboard)
+      core.use(RemoteSources, { sources: ['Webcam'] })
+    }).toThrow(new Error('Please specify companionUrl for RemoteSources to work, see https://uppy.io/docs/remote-sources#companionUrl'))
+  })
+
+  it('should throw when trying to use a plugin which is not included in RemoteSources', () => {
+    expect(() => {
+      const core = new Core()
+      core.use(Dashboard)
+      core.use(RemoteSources, {
+        companionUrl: 'https://example.com',
+        sources: ['Webcam'],
+      })
+    }).toThrow()
+  })
+})

packages/@uppy/remote-sources/types/index.d.ts

@@ -5,6 +5,7 @@ interface RemoteTargetOptions extends PluginOptions, RequestClientOptions {
   target?: PluginTarget
   sources?: Array<string>
   title?: string
+  companionUrl: string
 }
 
 declare class RemoteTarget extends BasePlugin<RemoteTargetOptions> {}

private/dev/Dashboard.js

@@ -86,7 +86,7 @@ export default () => {
     // .use(Unsplash, { target: Dashboard, companionUrl: COMPANION_URL })
     .use(RemoteSources, {
       companionUrl: COMPANION_URL,
-      sources: ['Box', 'Dropbox', 'Facebook', 'GoogleDrive', 'Instagram', 'OneDrive', 'Unsplash', 'Url'],
+      sources: ['Box', 'Dropbox', 'Webcam', 'Facebook', 'GoogleDrive', 'Instagram', 'OneDrive', 'Unsplash', 'Url'],
     })
     .use(Webcam, {
       target: Dashboard,