@uppy/companion: upgrade deps #5119
Draft
+14,200
−16,075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much simpler to copy their MIT implementation than to resolve ESM-CJS interop
aduh95
force-pushed
the
upgrade-yarn
branch
2 times, most recently
from
e16cb06
to
985f71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can depend on ESM dependency, we are able to upgrade (almost) all our deps. The only one that I didn't touch is
escape-string-regexp, because it is used in sync paths only.This is on top the
upgrade-yarnbranch, so publishing as draft for now.