@uppy/transloadit: do not cancel assembly when removing all files

[Murderlon]

A common use case is clear the state of Uppy (with setTimeout) after success. But the @uppy/transloadit plugin cancels all assemblies, even if in progress, when that happens. This is causing issues for two customers.

[github-actions]

Diff output files

diff --git a/packages/@uppy/transloadit/lib/index.js b/packages/@uppy/transloadit/lib/index.js
index 31e4d6c..65b38d9 100644
--- a/packages/@uppy/transloadit/lib/index.js
+++ b/packages/@uppy/transloadit/lib/index.js
@@ -644,13 +644,7 @@ function _createAssembly2(fileIDs, uploadID, assemblyOptions) {
       } else if (fileRemoved.id in updatedFiles) {
         delete updatedFiles[fileRemoved.id];
         const nbOfRemainingFiles = Object.keys(updatedFiles).length;
-        if (nbOfRemainingFiles === 0) {
-          assembly.close();
-          _classPrivateFieldLooseBase(this, _cancelAssembly)[_cancelAssembly](newAssembly).catch(() => {});
-          this.uppy.off("file-removed", fileRemovedHandler);
-        } else {
-          this.client.updateNumberOfFilesInAssembly(newAssembly, nbOfRemainingFiles).catch(() => {});
-        }
+        this.client.updateNumberOfFilesInAssembly(newAssembly, nbOfRemainingFiles).catch(() => {});
       }
     };
     this.uppy.on("file-removed", fileRemovedHandler);

[aduh95]

Could you add at least a TODO in the test so we don't forget it's a scenario we want to validate?

[Murderlon]

Could you add at least a TODO in the test so we don't forget it's a scenario we want to validate?

Already working on this in a different branch so not needed I think :)