Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating aws-nodejs example listParts logic for resuming uploads #5192

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

Mitchell8210
Copy link
Contributor

updating aws-nodejs example listParts logic for resuming uploads, resolves invalid signature error.

@aduh95 aduh95 linked an issue May 23, 2024 that may be closed by this pull request
2 tasks
@Mitchell8210 Mitchell8210 requested a review from aduh95 June 9, 2024 03:32
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
examples/aws-nodejs/index.js Outdated Show resolved Hide resolved
Copy link
Member

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a change to fix the linter and simplify the diff. If you can confirm that it does still fix the issue, I think we can land this!

@Mitchell8210
Copy link
Contributor Author

Those changes look good and will still fix the issue, I appreciate the help!

@aduh95 aduh95 merged commit a5bc28a into transloadit:main Jun 17, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jun 18, 2024
github-actions bot added a commit that referenced this pull request Jun 18, 2024
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/box            |   2.4.0 | @uppy/onedrive       |   3.4.0 |
| @uppy/companion      |  4.14.0 | @uppy/provider-views |  3.13.0 |
| @uppy/core           |  3.13.0 | @uppy/react          |   3.4.0 |
| @uppy/dashboard      |   3.9.0 | @uppy/remote-sources |   1.3.0 |
| @uppy/dropbox        |   3.4.0 | @uppy/transloadit    |   3.8.0 |
| @uppy/google-drive   |   3.6.0 | uppy                 |  3.27.0 |
| @uppy/google-photos  |   0.1.0 |                      |         |

- @uppy/google-photos: add plugin (Mikael Finstad / #5061)
- examples: updating aws-nodejs example listParts logic for resuming uploads (Mitchell Rhoads / #5192)
- meta: Bump docker/login-action from 3.1.0 to 3.2.0 (dependabot\[bot] / #5217)
- meta: Bump docker/build-push-action from 5.3.0 to 5.4.0 (dependabot\[bot] / #5252)
- @uppy/transloadit: also fix outdated assembly transloadit:result (Merlijn Vos / #5246)
- docs: fix typo in the url (Evgenia Karunus)
- @uppy/companion: Bump ws from 8.8.1 to 8.17.1 (dependabot\[bot] / #5256)
Murderlon added a commit that referenced this pull request Jun 20, 2024
* 4.x:
  @uppy/companion: fix merge conflicts
  Release: uppy@3.27.0 (#5257)
  Bump ws from 8.8.1 to 8.17.1 (#5256)
  @uppy/google-photos: add plugin (#5061)
  updating aws-nodejs example listParts logic for resuming uploads (#5192)
  Bump docker/login-action from 3.1.0 to 3.2.0 (#5217)
  Bump docker/build-push-action from 5.3.0 to 5.4.0 (#5252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-s3-multipart + golden retriever
2 participants