Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/audio: remove unused component props #5209

Merged
merged 3 commits into from
Jun 4, 2024
Merged

@uppy/audio: remove unused component props #5209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d30cfe6
@uppy/audio: remove unused component props
aduh95 May 31, 2024
35c1cd9
Merge branch '4.x' into audio-todo
aduh95 Jun 4, 2024
469cc68
fixup
aduh95 Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/@uppy/audio/src/Audio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ export interface AudioOptions extends UIPluginOptions {
interface AudioState {
audioReady: boolean
recordingLengthSeconds: number
recordedAudio: string | null | undefined
hasAudio: boolean
cameraError: null
audioSources: MediaDeviceInfo[]
currentDeviceId?: null | string | MediaStreamTrack
currentDeviceId: string | MediaStreamTrack | null | undefined
isRecording: boolean
showAudioSourceDropdown: boolean
[id: string]: unknown
Expand Down Expand Up @@ -130,7 +131,7 @@ export default class Audio<M extends Meta, B extends Body> extends UIPlugin<
.then((stream) => {
this.#stream = stream

let currentDeviceId = null
let currentDeviceId: AudioState['currentDeviceId'] = null
const tracks = stream.getAudioTracks()

if (!options?.deviceId) {
Expand Down Expand Up @@ -368,9 +369,6 @@ export default class Audio<M extends Meta, B extends Body> extends UIPlugin<
<RecordingScreen
// eslint-disable-next-line react/jsx-props-no-spreading
{...audioState}
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore TODO: remove unused
audioActive={this.#audioActive}
onChangeSource={this.#changeSource}
onStartRecording={this.#startRecording}
onStopRecording={this.#stopRecording}
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/audio/src/AudioSourceSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { h } from 'preact'

export interface AudioSourceSelectProps {
currentDeviceId: string
currentDeviceId: string | MediaStreamTrack | null | undefined
audioSources: MediaDeviceInfo[]
onChangeSource: (value: string) => void
}
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/audio/src/RecordingScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import DiscardButton from './DiscardButton.tsx'

interface RecordingScreenProps extends AudioSourceSelectProps {
stream: MediaStream | null | undefined
recordedAudio: string
recordedAudio: string | null | undefined
recording: boolean
supportsRecording: boolean
showAudioSourceDropdown: boolean | undefined
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/webcam/src/VideoSourceSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { h, type ComponentChild } from 'preact'

export interface VideoSourceSelectProps {
currentDeviceId: string | null
currentDeviceId: string | MediaStreamTrack | null | undefined
videoSources: MediaDeviceInfo[]
onChangeVideoSource: (deviceId: string) => void
}
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/webcam/src/Webcam.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ interface WebcamState {
cameraError: null
recordingLengthSeconds: number
videoSources: MediaDeviceInfo[]
currentDeviceId: null | string
currentDeviceId: string | MediaStreamTrack | null | undefined
isRecording: boolean
[key: string]: unknown
}
Expand Down