fix broken commit

[mifi]

accidentally introduced here 2f21ce9

note the documentation here which correctly describes how it should work

[github-actions]

Diff output files

diff --git a/packages/@uppy/companion/lib/server/Uploader.js b/packages/@uppy/companion/lib/server/Uploader.js
index a391f1f..da46ef5 100644
--- a/packages/@uppy/companion/lib/server/Uploader.js
+++ b/packages/@uppy/companion/lib/server/Uploader.js
@@ -421,13 +421,15 @@ class Uploader {
    */
   async #emitError(err) {
     // delete stack to avoid sending server info to client
+    // also remove extraData from inside the error object (it is provided outside)
     // see PR discussion https://github.com/transloadit/uppy/pull/3832
-    // @ts-ignore
     const { serializeError } = await import("serialize-error");
-    const { stack, ...serializedErr } = serializeError(err);
+    // @ts-ignore
+    const { stack, extraData, ...serializedErr } = serializeError(err);
     const dataToEmit = {
       action: "error",
-      payload: { error: serializedErr },
+      // @ts-ignore
+      payload: { ...extraData, error: serializedErr },
     };
     this.saveState(dataToEmit);
     emitter().emit(this.token, dataToEmit);

[aduh95]

I don't think this is a good change, we had a TODO for removing this, and this is just adding it back:

uppy/packages/@uppy/companion/src/server/Uploader.js

Line 506 in 3d8ff79

// todo remove also extraData from serializedErr in next major,

In any case, we should probably have a test for this, as this is a bit nebulous if we don't know what's the use case.

[mifi]

I don't think this is a good change, we had a TODO for removing this, and this is just adding it back:

extraData is still present in payload.error in the 4.x branch. My original PR removed it from payload.error (because it is already spread in payload). there was never any wish to remove it completely, but to de-duplicate it.

This PR replicates my original PR by removing extraData from payload.error which is what was originally intended. see discussion in #3832 (comment)

also our migration guide describes this:

The Companion error event now no longer includes extraData inside the payload.error property. extraData is (and was also before) included in the payload.

• if you agree to keep it, then i can write a test for it.
• if we don't want extraData to be included at all in the error event, then we should remove it from payload.error too.

[aduh95]

The thing is, this thing is undocumented (well except now in the migration guide that you authored) and untested. From what I understand in the TODO, we wanted to remove the special-casing of extraData that we don't use – so it would still be found in the error property, and no longer in the object. Now I understand it can be understand the other way around (like in this PR), which I didn't see until you explained.
I still think we should go with the simpler approach where we don't special-case extraData until someone comes up with a use-case – at which point we should add a test and document it.

[mifi]

ok, I agree that we can remove extraData because it's not documented anywhere.

I tried to remove extraData in 51b21a9 but as far as I understand, gotobusstop thought it was being used in (old versions of) Uppy: #3832 (review) so we kept it and added the TODO to remove it.

but if you think it's safe to remove it now, i'm not going to oppose that and we can close this PR

[aduh95]

Let's remove the now wrong note from the migration guide – after all, it's not an actionable item, and we don't expect that change to break anyone.