Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some appstream XML validation errors/warning. #53

Merged
merged 1 commit into from Jul 14, 2017

Conversation

ajf8
Copy link
Member

@ajf8 ajf8 commented Jul 11, 2017

I didn't get the message about the description being too short reported in issue #37

But there were some others which this hopefully fixes:

 appstreamcli validate data/transmission-remote-gtk.appdata.xml.in --verbose --pedantic
W - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop:19
    Found tag '_li' in section 'ul'. Only 'li' tags are allowed.

W - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop:10
    Found invalid tag: '_developer_name'. Non-standard tags must be prefixed with 
    "x-".

E - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop
    The component is missing a long description. Components of this type must have a 
    long description.

W - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop:18
    Found tag '_p' in 'description' section. Only 'p', 'ul' and 'ol' are allowed.

W - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop:15
    Found tag '_p' in 'description' section. Only 'p', 'ul' and 'ol' are allowed.

W - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop:4
    The component ID is not a reverse domain-name. Please update the ID and that of 
    the accompanying .desktop file to follow the latest version of the Desktop-Entry 
    and AppStream specifications and avoid future issues.

P - transmission-remote-gtk.appdata.xml.in:transmission-remote-gtk.desktop:4
    The component is part of the GNOME project, but its id does not start with 
    GNOMEs reverse-DNS name ("org.gnome").

Validation failed: errors: 1, warnings: 5, pedantic: 1

Transmission Remote Gtk allows you to remotely manage the Transmission BitTorrent client using its RPC interface.
</_p>
<_p>Features:</_p>
</p>
Copy link
Member

@TingPing TingPing Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you disabling translations?

EDIT: What i mean is, don't run the appstream tool on the .in file, run it on the output.

@@ -1,26 +1,25 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2014 Alan F -->
<component type="desktop">
<id>transmission-remote-gtk.desktop</id>
<id>uk.org.eth0.transmission-remote-gtk.desktop</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to actually rename the desktop file too of course.

@ajf8 ajf8 force-pushed the appstream_validation_fixes branch from 6093f9d to 90f8513 Compare July 14, 2017 20:41
@ajf8
Copy link
Member Author

ajf8 commented Jul 14, 2017

Hopefully fixed, thanks.

@ajf8 ajf8 merged commit 239ce19 into master Jul 14, 2017
@ajf8 ajf8 deleted the appstream_validation_fixes branch November 19, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants